diff --git a/src/com/android/settings/users/UserCapabilities.java b/src/com/android/settings/users/UserCapabilities.java index 084a5dbfb50..f1bfae90c97 100644 --- a/src/com/android/settings/users/UserCapabilities.java +++ b/src/com/android/settings/users/UserCapabilities.java @@ -34,6 +34,7 @@ public class UserCapabilities { boolean mCanAddGuest; boolean mDisallowAddUser; boolean mDisallowAddUserSetByAdmin; + boolean mDisallowSwitchUser; RestrictedLockUtils.EnforcedAdmin mEnforcedAdmin; private UserCapabilities() {} @@ -79,6 +80,9 @@ public class UserCapabilities { final boolean canAddUsersWhenLocked = mIsAdmin || Settings.Global.getInt( context.getContentResolver(), Settings.Global.ADD_USERS_WHEN_LOCKED, 0) == 1; mCanAddGuest = !mIsGuest && !mDisallowAddUser && canAddUsersWhenLocked; + + UserManager userManager = (UserManager) context.getSystemService(Context.USER_SERVICE); + mDisallowSwitchUser = userManager.hasUserRestriction(UserManager.DISALLOW_USER_SWITCH); } public boolean isAdmin() { @@ -109,6 +113,7 @@ public class UserCapabilities { ", mCanAddGuest=" + mCanAddGuest + ", mDisallowAddUser=" + mDisallowAddUser + ", mEnforcedAdmin=" + mEnforcedAdmin + + ", mDisallowSwitchUser=" + mDisallowSwitchUser + '}'; } } diff --git a/src/com/android/settings/users/UserSettings.java b/src/com/android/settings/users/UserSettings.java index fcb8aef0b47..edeab2372e3 100644 --- a/src/com/android/settings/users/UserSettings.java +++ b/src/com/android/settings/users/UserSettings.java @@ -757,8 +757,12 @@ public class UserSettings extends SettingsPreferenceFragment synchronized (mUserLock) { if (userType == USER_TYPE_USER) { mHandler.sendEmptyMessage(MESSAGE_UPDATE_LIST); - mHandler.sendMessage(mHandler.obtainMessage( - MESSAGE_SETUP_USER, user.id, user.serialNumber)); + // Skip setting up user which results in user switching when the + // restriction is set. + if (!mUserCaps.mDisallowSwitchUser) { + mHandler.sendMessage(mHandler.obtainMessage( + MESSAGE_SETUP_USER, user.id, user.serialNumber)); + } } else { mHandler.sendMessage(mHandler.obtainMessage( MESSAGE_CONFIG_USER, user.id, user.serialNumber)); @@ -845,8 +849,12 @@ public class UserSettings extends SettingsPreferenceFragment } else { pref.setSummary(R.string.user_summary_not_set_up); } - pref.setOnPreferenceClickListener(this); - pref.setSelectable(true); + // Disallow setting up user which results in user switching when the restriction is + // set. + if (!mUserCaps.mDisallowSwitchUser) { + pref.setOnPreferenceClickListener(this); + pref.setSelectable(true); + } } else if (user.isRestricted()) { pref.setSummary(R.string.user_summary_restricted_profile); } @@ -885,8 +893,13 @@ public class UserSettings extends SettingsPreferenceFragment pref.setTitle(R.string.user_guest); pref.setIcon(getEncircledDefaultIcon()); userPreferences.add(pref); - pref.setDisabledByAdmin( - mUserCaps.mDisallowAddUser ? mUserCaps.mEnforcedAdmin : null); + if (mUserCaps.mDisallowAddUser) { + pref.setDisabledByAdmin(mUserCaps.mEnforcedAdmin); + } else if (mUserCaps.mDisallowSwitchUser) { + pref.setDisabledByAdmin(RestrictedLockUtils.getDeviceOwner(context)); + } else { + pref.setDisabledByAdmin(null); + } int finalGuestId = guestId; pref.setOnPreferenceClickListener(preference -> { int id = finalGuestId; diff --git a/tests/robotests/src/com/android/settings/users/UserCapabilitiesTest.java b/tests/robotests/src/com/android/settings/users/UserCapabilitiesTest.java new file mode 100644 index 00000000000..4228ca0d132 --- /dev/null +++ b/tests/robotests/src/com/android/settings/users/UserCapabilitiesTest.java @@ -0,0 +1,70 @@ +/* + * Copyright (C) 2018 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.users; + +import static com.google.common.truth.Truth.assertThat; + +import static org.mockito.Mockito.when; + +import android.content.Context; +import android.os.UserManager; + +import com.android.settings.TestConfig; +import com.android.settings.testutils.SettingsRobolectricTestRunner; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.robolectric.annotation.Config; + +@RunWith(SettingsRobolectricTestRunner.class) +@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION) +public class UserCapabilitiesTest { + + @Mock + private Context mContext; + @Mock + private UserManager mUserManager; + + @Before + public void setUp() { + MockitoAnnotations.initMocks(this); + when(mContext.getSystemService(Context.USER_SERVICE)).thenReturn(mUserManager); + } + + @Test + public void disallowUserSwitchWhenRestrictionIsSet() { + when(mUserManager.hasUserRestriction(UserManager.DISALLOW_USER_SWITCH)).thenReturn(true); + + UserCapabilities userCapabilities = UserCapabilities.create(mContext); + userCapabilities.updateAddUserCapabilities(mContext); + + assertThat(userCapabilities.mDisallowSwitchUser).isTrue(); + } + + @Test + public void allowUserSwitchWhenRestrictionIsNotSet() { + when(mUserManager.hasUserRestriction(UserManager.DISALLOW_USER_SWITCH)).thenReturn(false); + + UserCapabilities userCapabilities = UserCapabilities.create(mContext); + userCapabilities.updateAddUserCapabilities(mContext); + + assertThat(userCapabilities.mDisallowSwitchUser).isFalse(); + } +}