From 84c3f60ef539c6ee2579c70a47d83226528de799 Mon Sep 17 00:00:00 2001 From: Amin Shaikh Date: Thu, 27 Jun 2019 17:40:39 -0400 Subject: [PATCH] Update ic_sync_problem to GM2. - Use tint instead of custom fillColor to be consistent with overlays. - Standardize on using @android:color/white as fill color - Update list of overlayed icons. Bug: 131346125 Test: make Change-Id: I4bc88e5842ba2f149356929a77b81459ce5042c5 --- res/drawable/ic_settings_disable.xml | 9 +++++---- res/drawable/ic_settings_enable.xml | 5 +++-- res/drawable/ic_sync_problem_24dp.xml | 4 ++-- tests/robotests/res/values/overlayable_icons_test.xml | 3 +++ 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/res/drawable/ic_settings_disable.xml b/res/drawable/ic_settings_disable.xml index d0edf4a4bd3..e7a8f4116cb 100644 --- a/res/drawable/ic_settings_disable.xml +++ b/res/drawable/ic_settings_disable.xml @@ -18,8 +18,9 @@ android:width="24dp" android:height="24dp" android:viewportWidth="24" - android:viewportHeight="24"> - + android:viewportHeight="24" + android:tint="?android:attr/colorControlNormal"> + diff --git a/res/drawable/ic_settings_enable.xml b/res/drawable/ic_settings_enable.xml index 560daef774a..673471d874e 100644 --- a/res/drawable/ic_settings_enable.xml +++ b/res/drawable/ic_settings_enable.xml @@ -18,8 +18,9 @@ android:width="24dp" android:height="24dp" android:viewportWidth="24" - android:viewportHeight="24"> + android:viewportHeight="24" + android:tint="?android:attr/colorControlNormal"> diff --git a/res/drawable/ic_sync_problem_24dp.xml b/res/drawable/ic_sync_problem_24dp.xml index 2139e98ec90..200a1b0ebbf 100644 --- a/res/drawable/ic_sync_problem_24dp.xml +++ b/res/drawable/ic_sync_problem_24dp.xml @@ -21,6 +21,6 @@ android:viewportHeight="24.0" android:tint="?android:attr/colorControlNormal"> + android:fillColor="@android:color/white" + android:pathData="M11 4.07v2.02C8.17 6.57 6 9.03 6 12c0 2.22 1.21 4.15 3 5.19V14h2v6H5v-2h1.74C5.07 16.54 4 14.4 4 12c0-4.08 3.05-7.44 7-7.93zm8.51 10.67c0.3 0.52 0.49 1.11 0.49 1.76 0 1.93-1.57 3.5-3.5 3.5-0.65 0-1.25-0.19-1.77-0.49-0.65-0.38-1.17-0.96-1.46-1.67-0.17-0.41-0.27-0.87-0.27-1.34 0-1.93 1.57-3.5 3.5-3.5 0.48 0 0.93 0.1 1.35 0.27 0.09-0.41 0.15 -0.83 0.15 -1.27 0-2.22-1.21-4.15-3-5.19V10h-2V4h6v2h-1.74C18.93 7.46 20 9.6 20 12c0 0.96-0.18 1.89-0.49 2.74zM17 18h-1v1h1v-1zm0-4h-1v3h1v-3z" /> diff --git a/tests/robotests/res/values/overlayable_icons_test.xml b/tests/robotests/res/values/overlayable_icons_test.xml index b3a43aacec5..0dab9cf4ac5 100644 --- a/tests/robotests/res/values/overlayable_icons_test.xml +++ b/tests/robotests/res/values/overlayable_icons_test.xml @@ -69,7 +69,9 @@ @drawable/ic_settings_data_usage @drawable/ic_settings_date_time @drawable/ic_settings_delete + @drawable/ic_settings_disable @drawable/ic_settings_display_white + @drawable/ic_settings_enable @drawable/ic_settings_home @drawable/ic_settings_language @drawable/ic_settings_location @@ -86,6 +88,7 @@ @drawable/ic_storage_white @drawable/ic_suggestion_night_display @drawable/ic_sync + @drawable/ic_sync_problem_24dp @drawable/ic_system_update @drawable/ic_videogame_vd_theme_24 @drawable/ic_volume_ringer_vibrate