From 66a96d220e1d8fadf497313e45901dd350a898b7 Mon Sep 17 00:00:00 2001 From: menghanli Date: Wed, 24 Aug 2022 19:35:38 +0800 Subject: [PATCH] Fix tapping magnification crash in vision settings setup screen Root cause: ag/17286343 introduces hiding the settings entry in magnification settings if window magnification feature is not supported. It causes SuW page cannot find the settings preference reference. Solution: Add null pointer check. Bug: 242242266 Test: Manual testing Change-Id: I1007a580047dd302228b28c15b82e958a2b01fec (cherry picked from commit 5a87f6bbbfb2cb21f2f9e398d5e6fae7f756b3f5) --- ...agnificationPreferenceFragmentForSetupWizard.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java index cb5ca759df1..12a988603d8 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragmentForSetupWizard.java @@ -52,11 +52,17 @@ public class ToggleScreenMagnificationPreferenceFragmentForSetupWizard */ private void hidePreferenceSettingComponents() { // Intro - mTopIntroPreference.setVisible(false); + if (mTopIntroPreference != null) { + mTopIntroPreference.setVisible(false); + } // Setting of magnification type - mSettingsPreference.setVisible(false); + if (mSettingsPreference != null) { + mSettingsPreference.setVisible(false); + } // Setting of following typing - mFollowingTypingSwitchPreference.setVisible(false); + if (mFollowingTypingSwitchPreference != null) { + mFollowingTypingSwitchPreference.setVisible(false); + } } @Override