diff --git a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java index 17e0d1ca63c..060a9f7cf27 100644 --- a/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java +++ b/tests/robotests/src/com/android/settings/dashboard/profileselector/ProfileSelectFragmentTest.java @@ -170,7 +170,8 @@ public class ProfileSelectFragmentTest { @Test public void getTabId_setPrivateId_getCorrectTab() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final Bundle bundle = new Bundle(); bundle.putInt(EXTRA_USER_ID, 11); mUserManager.setPrivateProfile(11, "private", 0); @@ -200,7 +201,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenOnlyPersonal_returnsOneFragment() { - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); Fragment[] fragments = ProfileSelectFragment.getFragments( @@ -235,7 +237,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenPrivateEnabled_returnsTwoFragments() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -257,7 +260,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenManagedProfile_returnsTwoFragments() { - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -279,7 +283,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenAllProfiles_returnsThreeFragments() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( @@ -303,7 +308,8 @@ public class ProfileSelectFragmentTest { @Test public void testGetFragments_whenAvailableBundle_returnsFragmentsWithCorrectBundles() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUserManager.addProfile( new UserInfo(0, PRIMARY_USER_NAME, null, 0, USER_TYPE_FULL_SYSTEM)); mUserManager.addProfile( diff --git a/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt b/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt index b5a4fe989cc..b792959acba 100644 --- a/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt +++ b/tests/uitests/src/com/android/settings/ui/SecuritySettingsTest.kt @@ -49,7 +49,8 @@ class SecuritySettingsTest { } @Test - @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) + @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES) fun privateSpace_ifFlagON() { device.assertHasTexts(listOf("Private Space")) } diff --git a/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt b/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt index 8eadd9dde92..14feb49adc1 100644 --- a/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt +++ b/tests/uitests/src/com/android/settings/ui/privatespace/PrivateSpaceAuthenticationActivityTest.kt @@ -38,7 +38,8 @@ import org.junit.runner.RunWith @RunWith(AndroidJUnit4::class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES) class PrivateSpaceAuthenticationActivityTest { private val device = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation()) diff --git a/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java b/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java index a671a45b448..3a330f21a23 100644 --- a/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java +++ b/tests/unit/src/com/android/settings/biometrics/combination/CombinedBiometricStatusUtilsTest.java @@ -310,7 +310,8 @@ public class CombinedBiometricStatusUtilsTest { when(mFaceManager.hasEnrolledTemplates(anyInt())).thenReturn(false); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mCombinedBiometricStatusUtils.getPrivateProfileSettingsClassName()) .isEqualTo(Settings.PrivateSpaceBiometricSettingsActivity.class.getName()); diff --git a/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java index f1da363b5e9..857135f419f 100644 --- a/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/FaceFingerprintUnlockControllerTest.java @@ -75,7 +75,8 @@ public class FaceFingerprintUnlockControllerTest { public void getAvailabilityStatus_whenFlagsEnabled_returnsAvailable() { mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(true); } @@ -83,18 +84,33 @@ public class FaceFingerprintUnlockControllerTest { /** Tests that the controller is not available when Biometrics flag is not enabled. */ @Test public void getAvailabilityStatus_whenBiometricFlagDisabled_returnsFalse() { - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mSetFlagsRule.disableFlags( android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); } - /** Tests that the controller is not available when private feature flag is not enabled. */ + /** + * Tests that the controller is not available when the main private space flag is not + * enabled. + */ @Test - public void getAvailabilityStatus_whenPrivateFlagDisabled_returnsFalse() { + public void getAvailabilityStatus_whenPsMainFlagDisabled_returnsFalse() { mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); mSetFlagsRule.enableFlags( + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); + + assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); + } + + /** Tests that the controller is not available when private features flag is not enabled. */ + @Test + public void getAvailabilityStatus_whenPsFeaturesFlagDisabled_returnsFalse() { + mSetFlagsRule.disableFlags(android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); assertThat(mFaceFingerprintUnlockController.isAvailable()).isEqualTo(false); @@ -106,7 +122,8 @@ public class FaceFingerprintUnlockControllerTest { doReturn(false).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFaceFingerprintUnlockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isFalse(); @@ -119,7 +136,8 @@ public class FaceFingerprintUnlockControllerTest { doReturn(true).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); mSetFlagsRule.enableFlags( android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_ENABLE_BIOMETRICS_TO_UNLOCK_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFaceFingerprintUnlockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java index 0abe3146f4f..b71547b65e2 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceControllerTest.java @@ -40,7 +40,8 @@ import org.junit.Test; import org.junit.runner.RunWith; @RunWith(AndroidJUnit4.class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public class HidePrivateSpaceControllerTest { @Rule public final CheckFlagsRule mCheckFlagsRule = diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java index 1430dfd1736..88503a525b6 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSensitiveNotificationsControllerTest.java @@ -67,7 +67,8 @@ public class HidePrivateSpaceSensitiveNotificationsControllerTest { mSetFlagsRule.enableFlags( android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateProfileId = PrivateSpaceMaintainer.getInstance( mContext).getPrivateProfileHandle().getIdentifier(); @@ -143,7 +144,8 @@ public class HidePrivateSpaceSensitiveNotificationsControllerTest { public void getAvailabilityStatus_flagDisabled() { mSetFlagsRule.disableFlags( android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); - mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.LOCK_SCREEN_SHOW_NOTIFICATIONS, 1); Settings.Secure.putInt(mContext.getContentResolver(), diff --git a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java index 39f7b9cbfa8..ed072d32587 100644 --- a/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/HidePrivateSpaceSummaryControllerTest.java @@ -40,7 +40,8 @@ import org.junit.Test; import org.junit.runner.RunWith; @RunWith(AndroidJUnit4.class) -@RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) +@RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public class HidePrivateSpaceSummaryControllerTest { @Rule public final CheckFlagsRule mCheckFlagsRule = diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java index 4c6feea36ab..8a7bd70e0ed 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceAuthenticationActivityTest.java @@ -88,7 +88,8 @@ public class PrivateSpaceAuthenticationActivityTest { /** Tests that when Private does not exist setup flow is started. */ //TODO(b/307729746) Plan to add more tests for complete setup flow @Test - @RequiresFlagsEnabled(Flags.FLAG_ALLOW_PRIVATE_PROFILE) + @RequiresFlagsEnabled({Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES}) public void whenPrivateProfileDoesNotExist_triggersSetupFlow() { when(mPrivateSpaceMaintainer.doesPrivateSpaceExist()).thenReturn(false); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java index 0d9db7e477b..c203a3cd72f 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceLockControllerTest.java @@ -80,7 +80,8 @@ public class PrivateSpaceLockControllerTest { /** Tests that the controller is always available. */ @Test public void getAvailabilityStatus_returnsAvailable() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mPrivateSpaceLockController.isAvailable()).isEqualTo(true); } @@ -89,7 +90,8 @@ public class PrivateSpaceLockControllerTest { @Test public void getSummary_whenScreenLock() { doReturn(false).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isFalse(); @@ -103,7 +105,8 @@ public class PrivateSpaceLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PATTERN) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); @@ -115,7 +118,8 @@ public class PrivateSpaceLockControllerTest { public void getSummary_whenProfileLockPin() { doReturn(true).when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PIN).when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); @@ -129,7 +133,8 @@ public class PrivateSpaceLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PASSWORD) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceLockController.updateState(mPreference); assertThat(mPreference.isEnabled()).isTrue(); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java index 8510b11c9c6..50f67d3c55b 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceMaintainerTest.java @@ -148,7 +148,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psDoesNotExist_setsDefaultPsSensitiveNotificationsValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE); + android.multiuser.Flags.FLAG_ENABLE_PS_SENSITIVE_NOTIFICATIONS_TOGGLE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); privateSpaceMaintainer.deletePrivateSpace(); @@ -259,7 +260,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psDoesNotExist_resetsPSAutoLockSettings() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final int autoLockOption = 2; PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); @@ -282,7 +284,8 @@ public class PrivateSpaceMaintainerTest { public void createPrivateSpace_psExists_doesNotResetPSAutoLockSettings() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); final int privateSpaceAutLockValue = 1; PrivateSpaceMaintainer privateSpaceMaintainer = PrivateSpaceMaintainer.getInstance(mContext); diff --git a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java index cf9ea051ebf..940f70d58f4 100644 --- a/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java +++ b/tests/unit/src/com/android/settings/privatespace/PrivateSpaceSafetySourceTest.java @@ -86,7 +86,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void onDeviceRebootedEvent_whenSafetyCenterEnabled_setsData() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -98,7 +99,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_whenFeatureDisabled_setsNullData() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -113,7 +115,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_setsEnabled() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); @@ -129,7 +132,8 @@ public class PrivateSpaceSafetySourceTest { @Test public void setSafetySourceData_setsPsAuthenticatorIntent() { when(mSafetyCenterManagerWrapper.isEnabled(mContext)).thenReturn(true); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); PrivateSpaceSafetySource.setSafetySourceData(mContext, EVENT_TYPE_DEVICE_REBOOTED); diff --git a/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java b/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java index 744a8ec8882..5c2a15cbd05 100644 --- a/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/UseOneLockControllerTest.java @@ -74,7 +74,8 @@ public class UseOneLockControllerTest { /** Tests that the controller is always available. */ @Test public void getAvailabilityStatus_returnsAvailable() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mUseOneLockController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -87,7 +88,8 @@ public class UseOneLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PATTERN) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("Pattern"); @@ -99,7 +101,8 @@ public class UseOneLockControllerTest { doReturn(true) .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PIN).when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("PIN"); @@ -112,7 +115,8 @@ public class UseOneLockControllerTest { .when(mLockPatternUtils).isSeparateProfileChallengeEnabled(anyInt()); doReturn(CREDENTIAL_TYPE_PASSWORD) .when(mLockPatternUtils).getCredentialTypeForUser(anyInt()); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mUseOneLockController.updateState(mPreference); assertThat(mUseOneLockController.getSummary().toString()).isEqualTo("Password"); diff --git a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java index 01381d8320b..45c2c7562ff 100644 --- a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockPreferenceControllerTest.java @@ -75,7 +75,8 @@ public class AutoLockPreferenceControllerTest { public void getAvailabilityStatus_withAutoLockFlagEnabled_returnsAvailable() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mAutoLockPreferenceController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -83,7 +84,8 @@ public class AutoLockPreferenceControllerTest { /** Tests that the controller is not available when auto lock flag is off. */ @Test public void getAvailabilityStatus_withAutoLockFlagDisabled_returnsNull() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mSetFlagsRule.disableFlags(android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); assertThat(mAutoLockPreferenceController.getAvailabilityStatus()) @@ -98,7 +100,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionEveryTimeDeviceLocks_returnsEveryTimeDeviceLocks() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, @@ -116,7 +119,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionAfter5MinutesOfInactivity_returnsAfter5MinutesOfInactivity() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, @@ -131,7 +135,8 @@ public class AutoLockPreferenceControllerTest { public void getSummary_whenOptionNever_returnsNever() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Settings.Secure.putInt( mContentResolver, diff --git a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java index 971ca40c8e1..1c620c068f3 100644 --- a/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/autolock/AutoLockSettingsFragmentTest.java @@ -94,7 +94,8 @@ public class AutoLockSettingsFragmentTest { public void verifyMetricsConstant() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } @@ -103,7 +104,8 @@ public class AutoLockSettingsFragmentTest { public void getCandidates_returnsCandidateInfoListWithAllKeys() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); final List candidates = mFragment.getCandidates(); @@ -120,7 +122,8 @@ public class AutoLockSettingsFragmentTest { public void getDefaultKey_returnsStoredAutoLockOptionsValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); @@ -144,7 +147,8 @@ public class AutoLockSettingsFragmentTest { public void setDefaultKey_storesCorrectAutoLockOptionValue() { mSetFlagsRule.enableFlags( Flags.FLAG_ALLOW_PRIVATE_PROFILE, - android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE); + android.multiuser.Flags.FLAG_SUPPORT_AUTOLOCK_FOR_PRIVATE_SPACE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment.onAttach(mContext); mFragment.setDefaultKey("2"); diff --git a/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java b/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java index 371ca240039..ed8decddf0e 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/DeletePrivateSpaceControllerTest.java @@ -58,7 +58,8 @@ public class DeletePrivateSpaceControllerTest { /** Tests that the controller is available when private space flag is enabled. */ @Test public void getAvailabilityStatus_whenPrivateFlagEnabled_returnsAvailable() { - mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mDeletePrivateSpaceController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @@ -66,7 +67,8 @@ public class DeletePrivateSpaceControllerTest { /** Tests that the controller is not available when private space flag is disabled. */ @Test public void getAvailabilityStatus_whenPrivateFlagDisabled_returnsUnsupportedOnDevice() { - mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(android.os.Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mDeletePrivateSpaceController.getAvailabilityStatus()) .isEqualTo(UNSUPPORTED_ON_DEVICE); diff --git a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java index 16ccbc451fc..5c48375c209 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeleteFragmentTest.java @@ -39,7 +39,8 @@ public class PrivateSpaceDeleteFragmentTest { @Test @UiThreadTest public void verifyMetricsConstant() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mFragment = spy(new PrivateSpaceDeleteFragment()); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } diff --git a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java index 5c2ef23564b..ffc1edf0c28 100644 --- a/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java +++ b/tests/unit/src/com/android/settings/privatespace/delete/PrivateSpaceDeletionProgressFragmentTest.java @@ -77,7 +77,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { @Test @UiThreadTest public void verifyMetricsConstant() { - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); assertThat(mFragment.getMetricsCategory()).isEqualTo(SettingsEnums.PRIVATE_SPACE_SETTINGS); } @@ -87,7 +88,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { public void deletePrivateSpace_deletesPS() { PrivateSpaceDeletionProgressFragment spyFragment = spy(mFragment); doNothing().when(spyFragment).showSuccessfulDeletionToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceMaintainer.createPrivateSpace(); spyFragment.deletePrivateSpace(); @@ -100,7 +102,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { public void deletePrivateSpace_onDeletion_showsDeletedToast() { PrivateSpaceDeletionProgressFragment spyFragment = spy(mFragment); doNothing().when(spyFragment).showSuccessfulDeletionToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); mPrivateSpaceMaintainer.createPrivateSpace(); spyFragment.deletePrivateSpace(); @@ -123,7 +126,8 @@ public class PrivateSpaceDeletionProgressFragmentTest { spyFragment.setPrivateSpaceMaintainer(injector); doReturn(DELETE_PS_ERROR_INTERNAL).when(mPrivateSpaceMaintainerMock).deletePrivateSpace(); doNothing().when(spyFragment).showDeletionInternalErrorToast(); - mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.enableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); spyFragment.deletePrivateSpace(); diff --git a/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java b/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java index 85bd0e2e7c6..cd4c3c64fe7 100644 --- a/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java +++ b/tests/unit/src/com/android/settings/safetycenter/SafetySourceBroadcastReceiverTest.java @@ -247,7 +247,8 @@ public class SafetySourceBroadcastReceiverTest { @Test public void onReceive_onRefresh_withPrivateSpaceFeatureDisabled_setsNullData() { when(mSafetyCenterManagerWrapper.isEnabled(mApplicationContext)).thenReturn(true); - mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE); + mSetFlagsRule.disableFlags(Flags.FLAG_ALLOW_PRIVATE_PROFILE, + android.multiuser.Flags.FLAG_ENABLE_PRIVATE_SPACE_FEATURES); Intent intent = new Intent()