From 0e4c59f7f6d57aae23344494c4eeb344fa00233b Mon Sep 17 00:00:00 2001
From: Fan Zhang <zhfan@google.com>
Date: Fri, 28 Apr 2017 12:23:30 -0700
Subject: [PATCH] Tweak spacing for horizontal preferences.

- Add minHeight to horizontal preference so they are not clustered
together.
- Wrap app_data_usage's into different categories so they don't rely on
SpacePreference to draw space and dividers.

Change-Id: Ieed90a39d48494d1207680483968b5733bdfb344
Fix: 37750568
Test: visual
(cherry picked from commit 9c93c28b5a9e3d1ff78b7ee4febcb39a5f447aeb)
---
 res/layout/horizontal_preference.xml |  5 ++-
 res/xml/app_data_usage.xml           | 65 +++++++++++++++-------------
 2 files changed, 37 insertions(+), 33 deletions(-)

diff --git a/res/layout/horizontal_preference.xml b/res/layout/horizontal_preference.xml
index b5871d95154..9358cff21b6 100644
--- a/res/layout/horizontal_preference.xml
+++ b/res/layout/horizontal_preference.xml
@@ -16,11 +16,12 @@
 -->
 
 
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
+    android:minHeight="?android:attr/listPreferredItemHeightSmall"
     android:orientation="horizontal"
-    android:paddingTop="1dp"
     android:paddingStart="@dimen/preference_no_icon_padding_start"
     android:paddingEnd="?android:attr/listPreferredItemPaddingEnd">
 
diff --git a/res/xml/app_data_usage.xml b/res/xml/app_data_usage.xml
index 520b93b9d4e..26a339a1921 100644
--- a/res/xml/app_data_usage.xml
+++ b/res/xml/app_data_usage.xml
@@ -15,48 +15,51 @@
 -->
 
 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
-    android:title="@string/data_usage_summary_title">
+                  android:title="@string/data_usage_summary_title">
 
     <com.android.settings.datausage.SpinnerPreference
         android:key="cycle" />
 
-    <com.android.settings.applications.SpacePreference
-        android:layout_height="8dp" />
+    <PreferenceCategory
+        android:key="app_data_usage_summary_category">
 
-    <Preference
-        android:key="total_usage"
-        android:title="@string/total_size_label"
-        android:selectable="false"
-        android:layout="@layout/horizontal_preference" />
+        <Preference
+            android:key="total_usage"
+            android:title="@string/total_size_label"
+            android:selectable="false"
+            android:layout="@layout/horizontal_preference" />
 
-    <Preference
-        android:key="foreground_usage"
-        android:title="@string/data_usage_label_foreground"
-        android:selectable="false"
-        android:layout="@layout/horizontal_preference" />
+        <Preference
+            android:key="foreground_usage"
+            android:title="@string/data_usage_label_foreground"
+            android:selectable="false"
+            android:layout="@layout/horizontal_preference" />
 
-    <Preference
-        android:key="background_usage"
-        android:title="@string/data_usage_label_background"
-        android:selectable="false"
-        android:layout="@layout/horizontal_preference" />
+        <Preference
+            android:key="background_usage"
+            android:title="@string/data_usage_label_background"
+            android:selectable="false"
+            android:layout="@layout/horizontal_preference" />
 
-    <com.android.settings.applications.SpacePreference
-        android:layout_height="8dp" />
+    </PreferenceCategory>
 
-    <Preference
-        android:key="app_settings"
-        android:title="@string/data_usage_app_settings" />
+    <PreferenceCategory
+        android:key="app_data_usage_settings_category">
+        <Preference
+            android:key="app_settings"
+            android:title="@string/data_usage_app_settings" />
 
-    <SwitchPreference
-        android:key="restrict_background"
-        android:title="@string/data_usage_app_restrict_background"
-        android:summary="@string/data_usage_app_restrict_background_summary" />
+        <SwitchPreference
+            android:key="restrict_background"
+            android:title="@string/data_usage_app_restrict_background"
+            android:summary="@string/data_usage_app_restrict_background_summary" />
 
-    <SwitchPreference
-        android:key="unrestricted_data_saver"
-        android:title="@string/unrestricted_app_title"
-        android:summary="@string/unrestricted_app_summary" />
+        <SwitchPreference
+            android:key="unrestricted_data_saver"
+            android:title="@string/unrestricted_app_title"
+            android:summary="@string/unrestricted_app_summary" />
+
+    </PreferenceCategory>
 
     <PreferenceCategory
         android:key="app_list"