diff --git a/Android.bp b/Android.bp index 8f7bd1befac..087030b37cf 100644 --- a/Android.bp +++ b/Android.bp @@ -132,6 +132,7 @@ android_library { flags_packages: [ "aconfig_settings_flags", "android.app.flags-aconfig", + "android.provider.flags-aconfig", ], } diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 11d97797474..cdd95355962 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -5297,7 +5297,7 @@ android:name="Settings$ContactsStorageSettingsActivity" android:label="@string/contacts_storage_settings_title" android:exported="true" - android:featureFlag="com.android.settings.flags.enable_contacts_default_account_in_settings"> + android:featureFlag="android.provider.new_default_account_api_enabled"> diff --git a/src/com/android/settings/applications/contacts/ContactsStoragePreferenceController.java b/src/com/android/settings/applications/contacts/ContactsStoragePreferenceController.java index 6c179da9325..dd227818b42 100644 --- a/src/com/android/settings/applications/contacts/ContactsStoragePreferenceController.java +++ b/src/com/android/settings/applications/contacts/ContactsStoragePreferenceController.java @@ -21,11 +21,11 @@ import android.accounts.Account; import android.content.Context; import android.os.UserHandle; import android.provider.ContactsContract.RawContacts.DefaultAccount.DefaultAccountAndState; +import android.provider.Flags; import android.util.Log; import com.android.settings.R; import com.android.settings.core.BasePreferenceController; -import com.android.settings.flags.Flags; import com.android.settingslib.accounts.AuthenticatorHelper; /** @@ -54,7 +54,7 @@ public class ContactsStoragePreferenceController extends BasePreferenceControlle @Override public int getAvailabilityStatus() { - return (Flags.enableContactsDefaultAccountInSettings() + return (Flags.newDefaultAccountApiEnabled() && mCurrentDefaultAccountAndState != null) ? AVAILABLE : CONDITIONALLY_UNAVAILABLE; } diff --git a/tests/robotests/src/com/android/settings/applications/contacts/ContactsStoragePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/applications/contacts/ContactsStoragePreferenceControllerTest.java index f55cbb44f72..45600c2e044 100644 --- a/tests/robotests/src/com/android/settings/applications/contacts/ContactsStoragePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/applications/contacts/ContactsStoragePreferenceControllerTest.java @@ -43,9 +43,9 @@ import android.platform.test.flag.junit.DeviceFlagsValueProvider; import android.platform.test.flag.junit.SetFlagsRule; import android.provider.ContactsContract; import android.provider.ContactsContract.RawContacts.DefaultAccount.DefaultAccountAndState; +import android.provider.Flags; import com.android.settings.R; -import com.android.settings.flags.Flags; import com.android.settings.testutils.shadow.ShadowAuthenticationHelper; import org.junit.Before; @@ -108,20 +108,20 @@ public class ContactsStoragePreferenceControllerTest { } @Test - @EnableFlags(Flags.FLAG_ENABLE_CONTACTS_DEFAULT_ACCOUNT_IN_SETTINGS) + @EnableFlags(Flags.FLAG_NEW_DEFAULT_ACCOUNT_API_ENABLED) public void getAvailabilityStatus_flagIsOn_shouldReturnAvailable() { assertThat(mPreferenceController.getAvailabilityStatus()).isEqualTo(AVAILABLE); } @Test - @RequiresFlagsDisabled(Flags.FLAG_ENABLE_CONTACTS_DEFAULT_ACCOUNT_IN_SETTINGS) + @RequiresFlagsDisabled(Flags.FLAG_NEW_DEFAULT_ACCOUNT_API_ENABLED) public void getAvailabilityStatus_flagIsOff_shouldReturnConditionallyUnavailable() { assertThat(mPreferenceController.getAvailabilityStatus()).isEqualTo( CONDITIONALLY_UNAVAILABLE); } @Test - @EnableFlags(Flags.FLAG_ENABLE_CONTACTS_DEFAULT_ACCOUNT_IN_SETTINGS) + @EnableFlags(Flags.FLAG_NEW_DEFAULT_ACCOUNT_API_ENABLED) public void getAvailabilityStatus_illegalStateExceptionThrown_shouldReturnConditionallyUnavailable() throws Exception { when(mContentProviderClient.call(eq(QUERY_DEFAULT_ACCOUNT_FOR_NEW_CONTACTS_METHOD), any(), @@ -135,7 +135,7 @@ public class ContactsStoragePreferenceControllerTest { } @Test - @EnableFlags(Flags.FLAG_ENABLE_CONTACTS_DEFAULT_ACCOUNT_IN_SETTINGS) + @EnableFlags(Flags.FLAG_NEW_DEFAULT_ACCOUNT_API_ENABLED) public void getAvailabilityStatus_runtimeExceptionThrown_shouldReturnConditionallyUnavailable() throws Exception { when(mContentProviderClient.call(eq(QUERY_DEFAULT_ACCOUNT_FOR_NEW_CONTACTS_METHOD), any(),