From 96aee4896b6b5ae0ba5f39ba1592a61d1dc1a5ab Mon Sep 17 00:00:00 2001
From: Kuan Wang <clairewang@google.com>
Date: Mon, 16 Jan 2023 12:07:07 +0800
Subject: [PATCH] Not show time information in battery optimization page when
 opened from Settings -> Apps

Test: make RunSettingsRoboTests + manual
Bug: 265130434
Change-Id: Ie7ae6a97041f490e81adbe8e0c530799e09a7c66
---
 .../appinfo/AppBatteryPreferenceController.java    |  4 ++--
 .../fuelgauge/AdvancedPowerUsageDetail.java        | 14 +++++++++-----
 .../spa/app/appinfo/AppBatteryPreference.kt        |  1 +
 .../spa/app/appinfo/AppBatteryPreferenceTest.kt    |  1 +
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/com/android/settings/applications/appinfo/AppBatteryPreferenceController.java b/src/com/android/settings/applications/appinfo/AppBatteryPreferenceController.java
index 2834983bdf7..212a61903f9 100644
--- a/src/com/android/settings/applications/appinfo/AppBatteryPreferenceController.java
+++ b/src/com/android/settings/applications/appinfo/AppBatteryPreferenceController.java
@@ -121,11 +121,11 @@ public class AppBatteryPreferenceController extends BasePreferenceController
             Log.i(TAG, "handlePreferenceTreeClick():\n" + mBatteryDiffEntry);
             AdvancedPowerUsageDetail.startBatteryDetailPage(
                     mParent.getActivity(),
-                    mParent,
+                    mParent.getMetricsCategory(),
                     mBatteryDiffEntry,
                     Utils.formatPercentage(
                             mBatteryDiffEntry.getPercentOfTotal(), /* round */ true),
-                    /*slotInformation=*/ null);
+                    /*slotInformation=*/ null, /*showTimeInformation=*/ false);
             return true;
         }
 
diff --git a/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java b/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java
index e9818fbceba..f3c64b78893 100644
--- a/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java
+++ b/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java
@@ -139,13 +139,15 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
             Activity caller, InstrumentedPreferenceFragment fragment,
             BatteryDiffEntry diffEntry, String usagePercent, String slotInformation) {
         startBatteryDetailPage(
-                caller, fragment.getMetricsCategory(), diffEntry, usagePercent, slotInformation);
+                caller, fragment.getMetricsCategory(), diffEntry, usagePercent, slotInformation,
+                /*showTimeInformation=*/ true);
     }
 
     /** Launches battery details page for an individual battery consumer fragment. */
     public static void startBatteryDetailPage(
             Context context, int sourceMetricsCategory,
-            BatteryDiffEntry diffEntry, String usagePercent, String slotInformation) {
+            BatteryDiffEntry diffEntry, String usagePercent, String slotInformation,
+            boolean showTimeInformation) {
         final BatteryHistEntry histEntry = diffEntry.mBatteryHistEntry;
         final LaunchBatteryDetailPageArgs launchArgs = new LaunchBatteryDetailPageArgs();
         // configure the launch argument.
@@ -156,9 +158,11 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
         launchArgs.mUid = (int) histEntry.mUid;
         launchArgs.mIconId = diffEntry.getAppIconId();
         launchArgs.mConsumedPower = (int) diffEntry.mConsumePower;
-        launchArgs.mForegroundTimeMs = diffEntry.mForegroundUsageTimeInMs;
-        launchArgs.mBackgroundTimeMs = diffEntry.mBackgroundUsageTimeInMs;
-        launchArgs.mScreenOnTimeMs = diffEntry.mScreenOnTimeInMs;
+        if (showTimeInformation) {
+            launchArgs.mForegroundTimeMs = diffEntry.mForegroundUsageTimeInMs;
+            launchArgs.mBackgroundTimeMs = diffEntry.mBackgroundUsageTimeInMs;
+            launchArgs.mScreenOnTimeMs = diffEntry.mScreenOnTimeInMs;
+        }
         launchArgs.mIsUserEntry = histEntry.isUserEntry();
         startBatteryDetailPage(context, sourceMetricsCategory, launchArgs);
     }
diff --git a/src/com/android/settings/spa/app/appinfo/AppBatteryPreference.kt b/src/com/android/settings/spa/app/appinfo/AppBatteryPreference.kt
index 2766dfef360..720422f6faf 100644
--- a/src/com/android/settings/spa/app/appinfo/AppBatteryPreference.kt
+++ b/src/com/android/settings/spa/app/appinfo/AppBatteryPreference.kt
@@ -126,6 +126,7 @@ private class AppBatteryPresenter(private val context: Context, private val app:
             this,
             Utils.formatPercentage(percentOfTotal, true),
             null,
+            false,
         )
     }
 
diff --git a/tests/spa_unit/src/com/android/settings/spa/app/appinfo/AppBatteryPreferenceTest.kt b/tests/spa_unit/src/com/android/settings/spa/app/appinfo/AppBatteryPreferenceTest.kt
index 01113ccb279..fd286caf2d9 100644
--- a/tests/spa_unit/src/com/android/settings/spa/app/appinfo/AppBatteryPreferenceTest.kt
+++ b/tests/spa_unit/src/com/android/settings/spa/app/appinfo/AppBatteryPreferenceTest.kt
@@ -162,6 +162,7 @@ class AppBatteryPreferenceTest {
                 batteryDiffEntry,
                 "10%",
                 null,
+                false,
             )
         }
     }