diff --git a/src/com/android/settings/development/featureflags/FeatureFlagsPreferenceController.java b/src/com/android/settings/development/featureflags/FeatureFlagsPreferenceController.java index 94636e9c712..f0b7961bb65 100644 --- a/src/com/android/settings/development/featureflags/FeatureFlagsPreferenceController.java +++ b/src/com/android/settings/development/featureflags/FeatureFlagsPreferenceController.java @@ -24,13 +24,13 @@ import androidx.preference.PreferenceGroup; import androidx.preference.PreferenceScreen; import com.android.settings.core.BasePreferenceController; -import com.android.settingslib.core.lifecycle.LifecycleObserver; -import com.android.settingslib.core.lifecycle.events.OnStart; import java.util.Map; -public class FeatureFlagsPreferenceController extends BasePreferenceController - implements LifecycleObserver, OnStart { +/** + * A {@link BasePreferenceController} used in {@link FeatureFlagsDashboard} + */ +public class FeatureFlagsPreferenceController extends BasePreferenceController { private PreferenceGroup mGroup; @@ -47,13 +47,6 @@ public class FeatureFlagsPreferenceController extends BasePreferenceController public void displayPreference(PreferenceScreen screen) { super.displayPreference(screen); mGroup = screen.findPreference(getPreferenceKey()); - } - - @Override - public void onStart() { - if (mGroup == null) { - return; - } final Map featureMap = FeatureFlagUtils.getAllFeatureFlags(); if (featureMap == null) { return; diff --git a/tests/robotests/src/com/android/settings/development/featureflags/FeatureFlagPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/featureflags/FeatureFlagPreferenceControllerTest.java index cf97544514a..acdf071dfa0 100644 --- a/tests/robotests/src/com/android/settings/development/featureflags/FeatureFlagPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/featureflags/FeatureFlagPreferenceControllerTest.java @@ -28,7 +28,6 @@ import static org.mockito.Mockito.when; import android.content.Context; import android.os.Build; -import android.os.SystemProperties; import androidx.preference.PreferenceCategory; import androidx.preference.PreferenceScreen; @@ -77,9 +76,8 @@ public class FeatureFlagPreferenceControllerTest { @Test public void onStart_shouldRefreshFeatureFlags() { - mController.onStart(); + mController.displayPreference(mScreen); - verify(mCategory).removeAll(); verify(mCategory, atLeastOnce()).addPreference(any(FeatureFlagPreference.class)); } }