From 34677c7b0824ba84e11f9445c8c5503df2a8415d Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Tue, 4 Jun 2024 13:15:51 -0700 Subject: [PATCH] Maybe fix NPE - don't notifyChange if selected visibility is the same Flag: none / bugfix Test: none / can't repro Test: manual - switch between the different radio buttons in bubble settings to make sure they all work Bug: 343167554 Change-Id: I19fc3fa0df59c44e3f22de035c0b377caea1158f --- .../android/settings/notification/app/BubblePreference.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/notification/app/BubblePreference.java b/src/com/android/settings/notification/app/BubblePreference.java index 29d6d30ca4e..17deef9e6f0 100644 --- a/src/com/android/settings/notification/app/BubblePreference.java +++ b/src/com/android/settings/notification/app/BubblePreference.java @@ -80,8 +80,10 @@ public class BubblePreference extends Preference implements RadioGroup.OnChecked } public void setSelectedVisibility(boolean visible) { - mSelectedVisible = visible; - notifyChanged(); + if (mSelectedVisible != visible) { + mSelectedVisible = visible; + notifyChanged(); + } } @Override