PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix broken app info Robolectric tests

Browse Source 
Fix: 253396248
Test: m RunSettingsRoboTests
Change-Id: I5ccc900824880c5d585b2838bbe3948232617288
This commit is contained in:
Chaohui Wang
2022-10-17 15:46:03 +08:00
parent 5d68c3f7b0
commit b25950d2cc
2 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/robotests/src/com/android/settings/applications/appinfo/ButtonActionDialogFragmentTest.java
View File

@@ -35,7 +35,6 @@ import com.android.settings.R;
import com.android.settings.testutils.shadow.ShadowAlertDialogCompat; import com.android.settings.testutils.shadow.ShadowAlertDialogCompat;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
@@ -73,14 +72,13 @@ public class ButtonActionDialogFragmentTest {
verify(mTargetFragment).handleDialogClick(anyInt()); verify(mTargetFragment).handleDialogClick(anyInt());
} }
@Ignore
@Test @Test
public void testOnClick_forceStop_dismissDialog() { public void testOnClick_forceStop_dismissDialog() {
ButtonActionDialogFragment fragment = ButtonActionDialogFragment fragment =
spy(ButtonActionDialogFragment.newInstance(FORCE_STOP_ID)); ButtonActionDialogFragment.newInstance(FORCE_STOP_ID);
FragmentController.setupFragment(fragment, FragmentActivity.class, 0 /* containerViewId */, FragmentController.setupFragment(fragment, FragmentActivity.class, 0 /* containerViewId */,
null /* bundle */); null /* bundle */);
doReturn(mTargetFragment).when(fragment).getTargetFragment(); fragment.setTargetFragment(mTargetFragment, 0);
doNothing().when(mTargetFragment).handleDialogClick(anyInt()); doNothing().when(mTargetFragment).handleDialogClick(anyInt());
final AlertDialog dialog = mock(AlertDialog.class); final AlertDialog dialog = mock(AlertDialog.class);

10
tests/robotests/src/com/android/settings/applications/appinfo/InstantAppButtonDialogFragmentTest.java
View File

@@ -37,7 +37,6 @@ import com.android.settings.R;
import com.android.settings.testutils.shadow.ShadowAlertDialogCompat; import com.android.settings.testutils.shadow.ShadowAlertDialogCompat;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.robolectric.Robolectric; import org.robolectric.Robolectric;
@@ -58,24 +57,23 @@ public class InstantAppButtonDialogFragmentTest {
public void setUp() { public void setUp() {
final FragmentActivity activity = Robolectric.setupActivity(FragmentActivity.class); final FragmentActivity activity = Robolectric.setupActivity(FragmentActivity.class);
mContext = spy(RuntimeEnvironment.application); mContext = spy(RuntimeEnvironment.application);
mFragment = spy(InstantAppButtonDialogFragment.newInstance(TEST_PACKAGE)); mFragment = InstantAppButtonDialogFragment.newInstance(TEST_PACKAGE);
mFragment.show(activity.getSupportFragmentManager(), "InstantAppButtonDialogFragment"); mFragment.show(activity.getSupportFragmentManager(), "InstantAppButtonDialogFragment");
doReturn(mContext).when(mFragment).getContext();
} }
@Ignore
@Test @Test
public void onClick_shouldDeleteApp() { public void onClick_shouldDeleteApp() {
final InstantAppButtonDialogFragment spyFragment = spy(mFragment);
doReturn(mContext).when(spyFragment).getContext();
final PackageManager packageManager = mock(PackageManager.class); final PackageManager packageManager = mock(PackageManager.class);
when(mContext.getPackageManager()).thenReturn(packageManager); when(mContext.getPackageManager()).thenReturn(packageManager);
mFragment.onClick(null /* dialog */, 0 /* which */); spyFragment.onClick(null /* dialog */, 0 /* which */);
verify(packageManager) verify(packageManager)
.deletePackageAsUser(eq(TEST_PACKAGE), any(), anyInt(), anyInt()); .deletePackageAsUser(eq(TEST_PACKAGE), any(), anyInt(), anyInt());
} }
@Ignore
@Test @Test
public void onCreateDialog_clearAppDialog_shouldShowClearAppDataConfirmation() { public void onCreateDialog_clearAppDialog_shouldShowClearAppDataConfirmation() {
final AlertDialog dialog = ShadowAlertDialogCompat.getLatestAlertDialog(); final AlertDialog dialog = ShadowAlertDialogCompat.getLatestAlertDialog();