From 995ca362c9efc162658ec9841bf4f9408b1e2139 Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Wed, 3 May 2017 11:23:33 -0700 Subject: [PATCH] Update "Phone idle" subtext Bug: 37897135 Test: RunSettingsRoboTests Change-Id: I38a63ef9fdf574ba277ed889e7e070c36ae14b01 --- .../android/settings/fuelgauge/PowerUsageAdvanced.java | 4 ++-- .../settings/fuelgauge/PowerUsageAdvancedTest.java | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/fuelgauge/PowerUsageAdvanced.java b/src/com/android/settings/fuelgauge/PowerUsageAdvanced.java index 6f73ae6b4cb..5ed495b8f21 100644 --- a/src/com/android/settings/fuelgauge/PowerUsageAdvanced.java +++ b/src/com/android/settings/fuelgauge/PowerUsageAdvanced.java @@ -275,8 +275,8 @@ public class PowerUsageAdvanced extends PowerUsageBase { if (usageData.usageList.size() <= 1) { CharSequence timeSequence = Utils.formatElapsedTime(getContext(), usageData.totalUsageTimeMs, false); - usageData.summary = TextUtils.expandTemplate(getText(R.string.battery_used_for), - timeSequence); + usageData.summary = usageData.usageType == UsageType.IDLE ? timeSequence + : TextUtils.expandTemplate(getText(R.string.battery_used_for), timeSequence); } else { BatterySipper sipper = findBatterySipperWithMaxBatteryUsage(usageData.usageList); BatteryEntry batteryEntry = new BatteryEntry(getContext(), mHandler, mUserManager, diff --git a/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageAdvancedTest.java b/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageAdvancedTest.java index 48eb02bd9bc..514da7924cf 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageAdvancedTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/PowerUsageAdvancedTest.java @@ -188,6 +188,16 @@ public class PowerUsageAdvancedTest { assertThat(mPowerUsageData.summary.toString()).isEqualTo(expectedSummary); } + @Test + public void testUpdateUsageDataSummary_typeIdle_showUsageTime() { + mPowerUsageData.usageType = UsageType.IDLE; + mPowerUsageData.usageList.add(mNormalBatterySipper); + + mPowerUsageAdvanced.updateUsageDataSummary(mPowerUsageData, TOTAL_POWER, DISCHARGE_AMOUNT); + + assertThat(mPowerUsageData.summary.toString()).isEqualTo("0m"); + } + @Test public void testUpdateUsageDataSummary_moreThanOneApp_showMaxUsageApp() { mPowerUsageData.usageList.add(mNormalBatterySipper);