PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Be more aggressive caching Vpn preference attrs

Browse Source 
As any change to the preference title will cause it to lose focus,
best not to do this too often.

Change-Id: Ibac27ee1de42fd7ca05f3e3685b84f37dac39517
Fix: 28191965
This commit is contained in:
Robin Lee
2016-04-21 12:56:21 +01:00
parent e06d757a0c
commit b166ea2668
4 changed files with 71 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/com/android/settings/vpn2/LegacyVpnPreference.java
View File

@@ -18,6 +18,7 @@ package com.android.settings.vpn2;
import android.content.Context;
import android.support.v7.preference.Preference;
import android.text.TextUtils;
import android.view.View;
import com.android.internal.net.VpnProfile;
@@ -33,6 +34,7 @@ public class LegacyVpnPreference extends ManageablePreference {
LegacyVpnPreference(Context context) {
super(context, null /* attrs */);
setIcon(R.mipmap.ic_launcher_settings);
}
public VpnProfile getProfile() {
@@ -40,12 +42,13 @@ public class LegacyVpnPreference extends ManageablePreference {
}
public void setProfile(VpnProfile profile) {
mProfile = profile;
if (mProfile != null) {
setIcon(R.mipmap.ic_launcher_settings);
setTitle(mProfile.name);
final String oldLabel = (mProfile != null ? mProfile.name : null);
final String newLabel = (profile != null ? profile.name : null);
if (!TextUtils.equals(oldLabel, newLabel)) {
setTitle(newLabel);
notifyHierarchyChanged();
}
notifyHierarchyChanged();
mProfile = profile;
}
@Override