1/n: Make ChooseLockSettingsHelper into a builder
The multitude of slightly different launchConfirmationActivity(*) methods are a big unsustainable pyramid. It's too difficult to read, too difficult to track which clients are interested in which parameters, and too difficult to add new parameters, since we need to 1) Read through all of them and find one that's the closest 2) Try not to affect other callers, so potentially add yet another 3) Modify the internal paths, which all basically call each other until it reaches the biggest launchConfirmationActivity which has ALL of the parameters This change should have no behavioral change. Note: CredentialStorage doesn't need returnCredentials anymore as of ag/6073449 Test: make -j56 RunSettingsRoboTests Test: Manually traced code paths for each invocation. A few hidden dependencies (such as explicitly setting challenge=0 with hasChallenge=true) were found. Left them the way they were in case they were intended Test: Enroll face, fingerprint Test: Enable developer options Test: Change to PIN, Pattern, Password, then back to PIN (so each type requests confirmation) Test: adb shell am start -a android.app.action.CONFIRM_DEVICE_CREDENTIAL, authenticate Test: adb shell am start -a android.app.action.CONFIRM_FRP_CREDENTIAL (shows confirm credential screen) Fixes: 138453993 Change-Id: Ic82ef3c3ac2e14d624281921f2d816bcdacbd82b
This commit is contained in:
@@ -85,8 +85,14 @@ public class StorageWizardMoveConfirm extends StorageWizardBase {
|
||||
Log.d(TAG, "User " + user.id + " is currently locked; requesting unlock");
|
||||
final CharSequence description = TextUtils.expandTemplate(
|
||||
getText(R.string.storage_wizard_move_unlock), user.name);
|
||||
new ChooseLockSettingsHelper(this).launchConfirmationActivityForAnyUser(
|
||||
REQUEST_CREDENTIAL, null, null, description, user.id);
|
||||
final ChooseLockSettingsHelper.Builder builder =
|
||||
new ChooseLockSettingsHelper.Builder(this);
|
||||
builder.setRequestCode(REQUEST_CREDENTIAL)
|
||||
.setDescription(description)
|
||||
.setUserId(user.id)
|
||||
.setChallenge(0L)
|
||||
.setAllowAnyUserId(true)
|
||||
.show();
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user