PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add the extra "Ask every time" if supported only" am: 7b9edcde47

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1455946

Change-Id: Ib2b9864613071c7a6819f03d5c1803b81b9a6575
This commit is contained in:
Amit Mahajan
2020-10-16 06:39:15 +00:00
committed by Automerger Merge Worker
parent 6d5943e6b8 7b9edcde47
commit b09f09b02d
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/com/android/settings/network/telephony/DefaultSubscriptionController.java
View File

@@ -83,6 +83,10 @@ public abstract class DefaultSubscriptionController extends TelephonyBasePrefere
/** Called to change the default subscription for the service. */ /** Called to change the default subscription for the service. */
protected abstract void setDefaultSubscription(int subscriptionId); protected abstract void setDefaultSubscription(int subscriptionId);
protected boolean isAskEverytimeSupported() {
return true;
}
@Override @Override
public int getAvailabilityStatus(int subId) { public int getAvailabilityStatus(int subId) {
final List<SubscriptionInfo> subs = SubscriptionUtil.getActiveSubscriptions(mManager); final List<SubscriptionInfo> subs = SubscriptionUtil.getActiveSubscriptions(mManager);
@@ -123,7 +127,11 @@ public abstract class DefaultSubscriptionController extends TelephonyBasePrefere
// display subscription based account // display subscription based account
return info.getDisplayName(); return info.getDisplayName();
} else { } else {
return mContext.getString(R.string.calls_and_sms_ask_every_time); if (isAskEverytimeSupported()) {
return mContext.getString(R.string.calls_and_sms_ask_every_time);
} else {
return "";
}
} }
} }
@@ -163,9 +171,12 @@ public abstract class DefaultSubscriptionController extends TelephonyBasePrefere
subIsAvailable = true; subIsAvailable = true;
} }
} }
// Add the extra "Ask every time" value at the end.
displayNames.add(mContext.getString(R.string.calls_and_sms_ask_every_time)); if (isAskEverytimeSupported()) {
subscriptionIds.add(Integer.toString(SubscriptionManager.INVALID_SUBSCRIPTION_ID)); // Add the extra "Ask every time" value at the end.
displayNames.add(mContext.getString(R.string.calls_and_sms_ask_every_time));
subscriptionIds.add(Integer.toString(SubscriptionManager.INVALID_SUBSCRIPTION_ID));
}
mPreference.setEntries(displayNames.toArray(new CharSequence[0])); mPreference.setEntries(displayNames.toArray(new CharSequence[0]));
mPreference.setEntryValues(subscriptionIds.toArray(new CharSequence[0])); mPreference.setEntryValues(subscriptionIds.toArray(new CharSequence[0]));

9
src/com/android/settings/network/telephony/SmsDefaultSubscriptionController.java
View File

@@ -23,8 +23,12 @@ import android.telephony.SubscriptionManager;
public class SmsDefaultSubscriptionController extends DefaultSubscriptionController { public class SmsDefaultSubscriptionController extends DefaultSubscriptionController {
private final boolean mIsAskEverytimeSupported;
public SmsDefaultSubscriptionController(Context context, String preferenceKey) { public SmsDefaultSubscriptionController(Context context, String preferenceKey) {
super(context, preferenceKey); super(context, preferenceKey);
mIsAskEverytimeSupported = mContext.getResources()
.getBoolean(com.android.internal.R.bool.config_sms_ask_every_time_support);
} }
@Override @Override
@@ -42,6 +46,11 @@ public class SmsDefaultSubscriptionController extends DefaultSubscriptionControl
mManager.setDefaultSmsSubId(subscriptionId); mManager.setDefaultSmsSubId(subscriptionId);
} }
@Override
protected boolean isAskEverytimeSupported() {
return mIsAskEverytimeSupported;
}
@Override @Override
public PhoneAccountHandle getDefaultCallingAccountHandle() { public PhoneAccountHandle getDefaultCallingAccountHandle() {
// Not supporting calling account override by VoIP // Not supporting calling account override by VoIP