Merge "Fix mSubscriptionInfoEntity NullPointerException" into main

This commit is contained in:
Chaohui Wang
2024-06-06 09:43:17 +00:00
committed by Android (Google) Code Review

View File

@@ -68,7 +68,6 @@ import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors; import java.util.concurrent.Executors;
import java.util.function.Consumer;
@SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC) @SearchIndexable(forTarget = SearchIndexable.ALL & ~SearchIndexable.ARC)
public class MobileNetworkSettings extends AbstractMobileNetworkSettings implements public class MobileNetworkSettings extends AbstractMobileNetworkSettings implements
@@ -359,24 +358,18 @@ public class MobileNetworkSettings extends AbstractMobileNetworkSettings impleme
} }
private void onSubscriptionDetailChanged() { private void onSubscriptionDetailChanged() {
if (mSubscriptionInfoEntity != null) { final SubscriptionInfoEntity subscriptionInfoEntity = mSubscriptionInfoEntity;
/** if (subscriptionInfoEntity == null) {
* Update the title when SIM stats got changed return;
*/
final Consumer<Activity> renameTitle = activity -> {
if (activity != null && !activity.isFinishing()) {
if (activity instanceof SettingsActivity) {
((SettingsActivity) activity).setTitle(mSubscriptionInfoEntity.uniqueName);
} }
}
};
ThreadUtils.postOnMainThread(() -> { ThreadUtils.postOnMainThread(() -> {
renameTitle.accept(getActivity()); if (getActivity() instanceof SettingsActivity activity && !activity.isFinishing()) {
// Update the title when SIM stats got changed
activity.setTitle(subscriptionInfoEntity.uniqueName);
}
redrawPreferenceControllers(); redrawPreferenceControllers();
}); });
} }
}
@Override @Override
public void onPause() { public void onPause() {