PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix marquee on app snippet in InstalledAppDetails

Browse Source 
First need to fix layout of the app_item as the widget was running
over the end of the view, do this by switching to a RelativeLayout.

Then select the view so it can actually marquee.

Bug: 22043942
Change-Id: Ieb94649ccf3dc8dcf56014c02fcdc06da71a9a62
This commit is contained in:
Jason Monk
2015-06-24 14:53:57 -04:00
parent 9dd754e1f4
commit b01459997e
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
res/layout/app_item.xml
View File

@@ -14,12 +14,13 @@
limitations under the License. limitations under the License.
--> -->
<GridLayout xmlns:android="http://schemas.android.com/apk/res/android" <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:minHeight="72dp" android:minHeight="72dp"
android:paddingTop="16dp" android:paddingTop="16dp"
android:paddingBottom="16dp" android:paddingBottom="16dp"
android:gravity="top"
android:columnCount="3"> android:columnCount="3">
<ImageView <ImageView
@@ -28,15 +29,14 @@
android:layout_height="@dimen/app_icon_size" android:layout_height="@dimen/app_icon_size"
android:layout_gravity="center" android:layout_gravity="center"
android:scaleType="fitXY" android:scaleType="fitXY"
android:layout_rowSpan="3"
android:layout_marginEnd="16dip" android:layout_marginEnd="16dip"
android:contentDescription="@null" /> android:contentDescription="@null" />
<TextView <TextView
android:id="@android:id/title" android:id="@android:id/title"
android:layout_width="0dip" android:layout_width="wrap_content"
android:layout_gravity="fill_horizontal" android:layout_height="wrap_content"
android:layout_marginTop="2dip" android:layout_toEndOf="@android:id/icon"
android:singleLine="true" android:singleLine="true"
android:ellipsize="marquee" android:ellipsize="marquee"
android:textAppearance="@android:style/TextAppearance.Material.Subhead" android:textAppearance="@android:style/TextAppearance.Material.Subhead"
@@ -45,8 +45,12 @@
<TextView <TextView
android:id="@android:id/summary" android:id="@android:id/summary"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_toEndOf="@android:id/title"
android:layout_alignParentEnd="true"
android:layout_marginStart="6dip" android:layout_marginStart="6dip"
android:layout_marginTop="2dip" android:gravity="end"
android:singleLine="true" android:singleLine="true"
android:ellipsize="marquee" android:ellipsize="marquee"
android:textAppearance="@android:style/TextAppearance.Material.Subhead" android:textAppearance="@android:style/TextAppearance.Material.Subhead"
@@ -54,8 +58,11 @@
<FrameLayout <FrameLayout
android:id="@android:id/widget_frame" android:id="@android:id/widget_frame"
android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_columnSpan="2" android:layout_toEndOf="@android:id/icon"
android:layout_below="@android:id/title"
android:layout_alignParentEnd="true"
android:layout_gravity="fill_horizontal|top" /> android:layout_gravity="fill_horizontal|top" />
</GridLayout> </RelativeLayout>

1
src/com/android/settings/applications/InstalledAppDetails.java
View File

@@ -763,6 +763,7 @@ public class InstalledAppDetails extends AppInfoBase
TextView appVersion = (TextView) appSnippet.findViewById(R.id.widget_text1); TextView appVersion = (TextView) appSnippet.findViewById(R.id.widget_text1);
if (!TextUtils.isEmpty(versionName)) { if (!TextUtils.isEmpty(versionName)) {
appVersion.setSelected(true);
appVersion.setVisibility(View.VISIBLE); appVersion.setVisibility(View.VISIBLE);
appVersion.setText(appSnippet.getContext().getString(R.string.version_text, appVersion.setText(appSnippet.getContext().getString(R.string.version_text,
String.valueOf(versionName))); String.valueOf(versionName)));