From 998e9b3197b93688f48277823db488d386aa209f Mon Sep 17 00:00:00 2001 From: Irfan Sheriff Date: Fri, 25 Jan 2013 14:37:20 -0800 Subject: [PATCH] Follow UX design guideline for frequency band Bug: 8019331 Change-Id: Ib87f4200ed42730d06485e339dc67cbb870b0538 --- .../android/settings/wifi/AdvancedWifiSettings.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/wifi/AdvancedWifiSettings.java b/src/com/android/settings/wifi/AdvancedWifiSettings.java index 809496ac083..dddb353f71c 100644 --- a/src/com/android/settings/wifi/AdvancedWifiSettings.java +++ b/src/com/android/settings/wifi/AdvancedWifiSettings.java @@ -100,6 +100,7 @@ public class AdvancedWifiSettings extends SettingsPreferenceFragment int value = mWifiManager.getFrequencyBand(); if (value != -1) { frequencyPref.setValue(String.valueOf(value)); + updateFrequencyBandSummary(frequencyPref, value); } else { Log.e(TAG, "Failed to fetch frequency band"); } @@ -145,6 +146,11 @@ public class AdvancedWifiSettings extends SettingsPreferenceFragment Log.e(TAG, "Invalid sleep policy value: " + value); } + private void updateFrequencyBandSummary(Preference frequencyBandPref, int index) { + String[] summaries = getResources().getStringArray(R.array.wifi_frequency_band_entries); + frequencyBandPref.setSummary(summaries[index]); + } + @Override public boolean onPreferenceTreeClick(PreferenceScreen screen, Preference preference) { String key = preference.getKey(); @@ -173,7 +179,9 @@ public class AdvancedWifiSettings extends SettingsPreferenceFragment if (KEY_FREQUENCY_BAND.equals(key)) { try { - mWifiManager.setFrequencyBand(Integer.parseInt((String) newValue), true); + int value = Integer.parseInt((String) newValue); + mWifiManager.setFrequencyBand(value, true); + updateFrequencyBandSummary(preference, value); } catch (NumberFormatException e) { Toast.makeText(getActivity(), R.string.wifi_setting_frequency_band_error, Toast.LENGTH_SHORT).show();