From 18ddc6525b1a8fd7ad9b241f4d4d896d55c19aaa Mon Sep 17 00:00:00 2001
From: menghanli <menghanli@google.com>
Date: Fri, 1 Apr 2022 10:52:03 +0800
Subject: [PATCH] Remove dependency of SudGlifTheme from SettingsTheme

Root cause: Inherit from the glif themes in setupdesign library
Solution: Not inherit from the glif themes and set Setting theme before
applying the dynamic color

Bug: 225800660
Test: Manual testing
Change-Id: Ic4d71bf7a754888c1ed1590c0483360d65f5da44
---
 res/values/themes_suw.xml                              | 10 ++++++++++
 .../AccessibilitySettingsForSetupWizardActivity.java   |  8 ++------
 .../android/settings/core/SettingsBaseActivity.java    |  8 ++------
 3 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/res/values/themes_suw.xml b/res/values/themes_suw.xml
index 129769f2b9e..1755d2a6776 100644
--- a/res/values/themes_suw.xml
+++ b/res/values/themes_suw.xml
@@ -244,6 +244,16 @@
         <item name="preferenceFragmentCompatStyle">@style/SetupWizardPreferenceFragmentStyle</item>
     </style>
 
+    <!-- This theme was applied to Settings pages which are running under SUW. -->
+    <style name="SettingsPreferenceTheme.SetupWizard" parent="@style/PreferenceTheme.SettingsLib">
+        <item name="android:textAppearanceListItem">@style/TextAppearance.PreferenceTitle.SettingsLib</item>
+        <item name="android:listPreferredItemPaddingStart">@dimen/settingslib_listPreferredItemPaddingStart</item>
+        <item name="android:listPreferredItemPaddingEnd">16dp</item>
+        <item name="preferenceTheme">@style/PreferenceTheme.SettingsLib</item>
+        <item name="android:switchStyle">@style/Switch.SettingsLib</item>
+        <item name="preferenceFragmentCompatStyle">@style/SetupWizardPreferenceFragmentStyle</item>
+    </style>
+
     <!-- DayNight themes -->
     <style name="GlifTheme.DayNight" parent="GlifTheme.Light" />
     <style name="GlifV2Theme.DayNight" parent="GlifV2Theme.Light" />
diff --git a/src/com/android/settings/accessibility/AccessibilitySettingsForSetupWizardActivity.java b/src/com/android/settings/accessibility/AccessibilitySettingsForSetupWizardActivity.java
index a7466dae974..e0a7ccc8166 100644
--- a/src/com/android/settings/accessibility/AccessibilitySettingsForSetupWizardActivity.java
+++ b/src/com/android/settings/accessibility/AccessibilitySettingsForSetupWizardActivity.java
@@ -102,11 +102,7 @@ public class AccessibilitySettingsForSetupWizardActivity extends SettingsActivit
 
     private void applyTheme() {
         setTheme(SetupWizardUtils.getTheme(this, getIntent()));
-        if (ThemeHelper.trySetDynamicColor(this)) {
-            final int appliedTheme = ThemeHelper.isSetupWizardDayNightEnabled(this)
-                    ? R.style.SudDynamicColorThemeSettings_SetupWizard_DayNight
-                    : R.style.SudDynamicColorThemeSettings_SetupWizard;
-            setTheme(appliedTheme);
-        }
+        setTheme(R.style.SettingsPreferenceTheme_SetupWizard);
+        ThemeHelper.trySetDynamicColor(this);
     }
 }
diff --git a/src/com/android/settings/core/SettingsBaseActivity.java b/src/com/android/settings/core/SettingsBaseActivity.java
index 12bada2b0d7..7842459f2e1 100644
--- a/src/com/android/settings/core/SettingsBaseActivity.java
+++ b/src/com/android/settings/core/SettingsBaseActivity.java
@@ -96,12 +96,8 @@ public class SettingsBaseActivity extends FragmentActivity implements CategoryHa
         final boolean isAnySetupWizard = WizardManagerHelper.isAnySetupWizard(getIntent());
         if (isAnySetupWizard && this instanceof SubSettings) {
             setTheme(SetupWizardUtils.getTheme(this, getIntent()));
-            if (ThemeHelper.trySetDynamicColor(this)) {
-                final int appliedTheme = ThemeHelper.isSetupWizardDayNightEnabled(this)
-                        ? R.style.SudDynamicColorThemeSettings_SetupWizard_DayNight
-                        : R.style.SudDynamicColorThemeSettings_SetupWizard;
-                setTheme(appliedTheme);
-            }
+            setTheme(R.style.SettingsPreferenceTheme_SetupWizard);
+            ThemeHelper.trySetDynamicColor(this);
         }
 
         if (isToolbarEnabled() && !isAnySetupWizard) {