From 0d964f76331ddbb09098f9f8489e7d9596084790 Mon Sep 17 00:00:00 2001 From: Alice Kuo Date: Mon, 29 Nov 2021 10:18:47 +0800 Subject: [PATCH] Minor clean-up for LE audio setting Bug: 178981521 Test: build pass Change-Id: Ica8bd68bea494ee72fa53fbb8f9101dc535470b6 --- .../bluetooth/BluetoothDetailsMacAddressController.java | 6 +++--- .../settings/bluetooth/BluetoothPairingController.java | 2 +- .../bluetooth/AvailableMediaBluetoothDeviceUpdaterTest.java | 4 ++-- .../bluetooth/ConnectedBluetoothDeviceUpdaterTest.java | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/com/android/settings/bluetooth/BluetoothDetailsMacAddressController.java b/src/com/android/settings/bluetooth/BluetoothDetailsMacAddressController.java index c5f845371b4..ec3e11fdaa2 100644 --- a/src/com/android/settings/bluetooth/BluetoothDetailsMacAddressController.java +++ b/src/com/android/settings/bluetooth/BluetoothDetailsMacAddressController.java @@ -52,12 +52,12 @@ public class BluetoothDetailsMacAddressController extends BluetoothDetailsContro @Override protected void refresh() { if (mCachedDevice.getGroupId() != BluetoothCsipSetCoordinator.GROUP_ID_INVALID) { - StringBuilder mTitle = new StringBuilder(mContext.getString( + StringBuilder title = new StringBuilder(mContext.getString( R.string.bluetooth_multuple_devices_mac_address, mCachedDevice.getAddress())); for (CachedBluetoothDevice member: mCachedDevice.getMemberDevice()) { - mTitle.append("\n").append(member.getAddress()); + title.append("\n").append(member.getAddress()); } - mFooterPreference.setTitle(mTitle); + mFooterPreference.setTitle(title); } else { mFooterPreference.setTitle(mContext.getString( R.string.bluetooth_device_mac_address, mCachedDevice.getAddress())); diff --git a/src/com/android/settings/bluetooth/BluetoothPairingController.java b/src/com/android/settings/bluetooth/BluetoothPairingController.java index ec5c8ddf912..b75e02a754a 100644 --- a/src/com/android/settings/bluetooth/BluetoothPairingController.java +++ b/src/com/android/settings/bluetooth/BluetoothPairingController.java @@ -94,7 +94,7 @@ public class BluetoothPairingController implements OnCheckedChangeListener, mPasskeyFormatted = formatKey(mPasskey); final CachedBluetoothDevice cachedDevice = mBluetoothManager.getCachedDeviceManager().findDevice(mDevice); - mIsCoordinatedSetMember = (cachedDevice != null) + mIsCoordinatedSetMember = cachedDevice != null ? cachedDevice.isCoordinatedSetMemberDevice() : false; } diff --git a/tests/robotests/src/com/android/settings/bluetooth/AvailableMediaBluetoothDeviceUpdaterTest.java b/tests/robotests/src/com/android/settings/bluetooth/AvailableMediaBluetoothDeviceUpdaterTest.java index 013ef5221f6..3cdff6e1eb6 100644 --- a/tests/robotests/src/com/android/settings/bluetooth/AvailableMediaBluetoothDeviceUpdaterTest.java +++ b/tests/robotests/src/com/android/settings/bluetooth/AvailableMediaBluetoothDeviceUpdaterTest.java @@ -235,7 +235,7 @@ public class AvailableMediaBluetoothDeviceUpdaterTest { } @Test - public void onProfileConnectionStateChanged_leAudioDeviceConnected_notInCall_addPreference() { + public void onProfileConnectionStateChanged_leAudioDeviceConnected_notInCall_addsPreference() { mAudioManager.setMode(AudioManager.MODE_NORMAL); when(mBluetoothDeviceUpdater .isDeviceConnected(any(CachedBluetoothDevice.class))).thenReturn(true); @@ -248,7 +248,7 @@ public class AvailableMediaBluetoothDeviceUpdaterTest { } @Test - public void onProfileConnectionStateChanged_leAudioDeviceConnected_inCall_addPreference() { + public void onProfileConnectionStateChanged_leAudioDeviceConnected_inCall_addsPreference() { mAudioManager.setMode(AudioManager.MODE_IN_CALL); when(mBluetoothDeviceUpdater .isDeviceConnected(any(CachedBluetoothDevice.class))).thenReturn(true); diff --git a/tests/robotests/src/com/android/settings/bluetooth/ConnectedBluetoothDeviceUpdaterTest.java b/tests/robotests/src/com/android/settings/bluetooth/ConnectedBluetoothDeviceUpdaterTest.java index 40b20dcaea3..98f1fe37fad 100644 --- a/tests/robotests/src/com/android/settings/bluetooth/ConnectedBluetoothDeviceUpdaterTest.java +++ b/tests/robotests/src/com/android/settings/bluetooth/ConnectedBluetoothDeviceUpdaterTest.java @@ -235,7 +235,7 @@ public class ConnectedBluetoothDeviceUpdaterTest { } @Test - public void onProfileConnectionStateChanged_leAudioDeviceConnected_inCall_removePreference() { + public void onProfileConnectionStateChanged_leAudioDeviceConnected_inCall_removesPreference() { mAudioManager.setMode(AudioManager.MODE_IN_CALL); when(mBluetoothDeviceUpdater .isDeviceConnected(any(CachedBluetoothDevice.class))).thenReturn(true); @@ -248,7 +248,7 @@ public class ConnectedBluetoothDeviceUpdaterTest { } @Test - public void onProfileConnectionStateChanged_leAudioDeviceConnected_notInCall_removePreference() + public void onProfileConnectionStateChanged_leAudioDeviceConnected_notInCall_removesPreference() { mAudioManager.setMode(AudioManager.MODE_NORMAL); when(mBluetoothDeviceUpdater