diff --git a/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java b/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java index 7308741dafb..5dfcc256122 100644 --- a/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java +++ b/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivity.java @@ -323,15 +323,10 @@ public class WifiDppConfiguratorActivity extends InstrumentedActivity implements @Override public boolean onNavigateUp() { - Fragment fragment = mFragmentManager.findFragmentById(R.id.fragment_container); - if (fragment instanceof WifiDppQrCodeGeneratorFragment) { + if (!mFragmentManager.popBackStackImmediate()) { finish(); - return true; - } else if (fragment instanceof WifiDppQrCodeScannerFragment) { - mFragmentManager.popBackStackImmediate(); } - - return false; + return true; } @Override diff --git a/tests/unit/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivityTest.java b/tests/unit/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivityTest.java index 38211b3ec1e..de788285902 100644 --- a/tests/unit/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivityTest.java +++ b/tests/unit/src/com/android/settings/wifi/dpp/WifiDppConfiguratorActivityTest.java @@ -175,4 +175,40 @@ public class WifiDppConfiguratorActivityTest { assertThat(restoredWifiNetworkConfig.getNetworkId()).isEqualTo(0); assertThat(restoredWifiNetworkConfig.isHotspot()).isTrue(); } + + @Test + public void launchScanner_onNavigateUp_shouldFinish() { + Intent intent = new Intent(WifiDppConfiguratorActivity.ACTION_CONFIGURATOR_QR_CODE_SCANNER); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_SECURITY, "WEP"); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_SSID, "GoogleGuest"); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_PRE_SHARED_KEY, "password"); + final Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation(); + + mActivityRule.launchActivity(intent); + + instrumentation.runOnMainSync(() -> { + mActivityRule.getActivity().onNavigateUp(); + + assertThat(mActivityRule.getActivity().isFinishing()).isEqualTo(true); + }); + } + + @Test + public void launchGenerator_onNavigateUp_shouldFinish() { + Intent intent = new Intent( + WifiDppConfiguratorActivity.ACTION_CONFIGURATOR_QR_CODE_GENERATOR); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_SECURITY, "WEP"); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_SSID, "GoogleGuest"); + intent.putExtra(WifiDppUtils.EXTRA_WIFI_PRE_SHARED_KEY, "password"); + final Instrumentation instrumentation = InstrumentationRegistry.getInstrumentation(); + + mActivityRule.launchActivity(intent); + + instrumentation.runOnMainSync(() -> { + mActivityRule.getActivity().onNavigateUp(); + + assertThat(mActivityRule.getActivity().isFinishing()).isEqualTo(true); + }); + } + }