Merge "Use correct category key for SecurityAdvancedSettings based on the type of active Security Settings"
This commit is contained in:
committed by
Android (Google) Code Review
commit
ac06c38866
@@ -25,6 +25,8 @@ import com.android.settings.biometrics.combination.CombinedBiometricProfileStatu
|
||||
import com.android.settings.biometrics.face.FaceProfileStatusPreferenceController;
|
||||
import com.android.settings.biometrics.fingerprint.FingerprintProfileStatusPreferenceController;
|
||||
import com.android.settings.dashboard.DashboardFragment;
|
||||
import com.android.settings.overlay.FeatureFactory;
|
||||
import com.android.settings.safetycenter.SafetyCenterStatus;
|
||||
import com.android.settings.search.BaseSearchIndexProvider;
|
||||
import com.android.settings.security.trustagent.TrustAgentListPreferenceController;
|
||||
import com.android.settings.widget.PreferenceCategoryController;
|
||||
@@ -47,6 +49,10 @@ public class SecurityAdvancedSettings extends DashboardFragment {
|
||||
private static final String TAG = "SecurityAdvancedSettings";
|
||||
private static final String WORK_PROFILE_SECURITY_CATEGORY = "security_category_profile";
|
||||
|
||||
/** Used in case of old Security settings when SafetyCenter is disabled */
|
||||
private static final String CATEGORY_SECURITY_LEGACY_ADVANCED_SETTINGS =
|
||||
"com.android.settings.category.ia.legacy_advanced_security";
|
||||
|
||||
@Override
|
||||
public int getMetricsCategory() {
|
||||
return SettingsEnums.SECURITY_ADVANCED;
|
||||
@@ -54,7 +60,19 @@ public class SecurityAdvancedSettings extends DashboardFragment {
|
||||
|
||||
@Override
|
||||
public String getCategoryKey() {
|
||||
return CategoryKey.CATEGORY_SECURITY_ADVANCED_SETTINGS;
|
||||
if (SafetyCenterStatus.isEnabled()) {
|
||||
return CategoryKey.CATEGORY_SECURITY_ADVANCED_SETTINGS;
|
||||
} else {
|
||||
final SecuritySettingsFeatureProvider securitySettingsFeatureProvider =
|
||||
FeatureFactory.getFactory(getContext())
|
||||
.getSecuritySettingsFeatureProvider();
|
||||
|
||||
if (securitySettingsFeatureProvider.hasAlternativeSecuritySettingsFragment()) {
|
||||
return securitySettingsFeatureProvider.getAlternativeAdvancedSettingsCategoryKey();
|
||||
} else {
|
||||
return CATEGORY_SECURITY_LEGACY_ADVANCED_SETTINGS;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
|
@@ -24,4 +24,10 @@ public interface SecuritySettingsFeatureProvider {
|
||||
|
||||
/** Returns the alternative SecuritySettings fragment name if available. */
|
||||
String getAlternativeSecuritySettingsFragmentClassname();
|
||||
|
||||
/**
|
||||
* Returns the category of SecurityAdvancedSettings fragment for the alternative
|
||||
* SecuritySettings if available.
|
||||
*/
|
||||
String getAlternativeAdvancedSettingsCategoryKey();
|
||||
}
|
||||
|
@@ -28,4 +28,9 @@ public class SecuritySettingsFeatureProviderImpl implements SecuritySettingsFeat
|
||||
public String getAlternativeSecuritySettingsFragmentClassname() {
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getAlternativeAdvancedSettingsCategoryKey() {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user