diff --git a/src/com/android/settings/wifi/WifiConnectListener.java b/src/com/android/settings/wifi/WifiConnectListener.java new file mode 100644 index 00000000000..b97fbc5e6e4 --- /dev/null +++ b/src/com/android/settings/wifi/WifiConnectListener.java @@ -0,0 +1,48 @@ +/* + * Copyright (C) 2019 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.wifi; + +import android.content.Context; +import android.net.wifi.WifiManager; +import android.widget.Toast; + +import com.android.settings.R; + +/** + * A listener to display a toast on failure to connect + */ +public class WifiConnectListener implements WifiManager.ActionListener { + + private final Context mContext; + + public WifiConnectListener(Context context) { + mContext = context; + } + + @Override + public void onSuccess() { + } + + @Override + public void onFailure(int reason) { + if (mContext != null) { + Toast.makeText(mContext, + R.string.wifi_failed_connect_message, + Toast.LENGTH_SHORT).show(); + } + } +} diff --git a/src/com/android/settings/wifi/WifiSettings.java b/src/com/android/settings/wifi/WifiSettings.java index 8e7b53a8388..e8d1b201c12 100644 --- a/src/com/android/settings/wifi/WifiSettings.java +++ b/src/com/android/settings/wifi/WifiSettings.java @@ -258,21 +258,7 @@ public class WifiSettings extends RestrictedSettingsFragment mConnectivityManager = getActivity().getSystemService(ConnectivityManager.class); } - mConnectListener = new WifiManager.ActionListener() { - @Override - public void onSuccess() { - } - - @Override - public void onFailure(int reason) { - Activity activity = getActivity(); - if (activity != null) { - Toast.makeText(activity, - R.string.wifi_failed_connect_message, - Toast.LENGTH_SHORT).show(); - } - } - }; + mConnectListener = new WifiConnectListener(getActivity()); mSaveListener = new WifiManager.ActionListener() { @Override diff --git a/src/com/android/settings/wifi/slice/ConnectToWifiHandler.java b/src/com/android/settings/wifi/slice/ConnectToWifiHandler.java index 064037e2e5d..6cf55d27b7e 100644 --- a/src/com/android/settings/wifi/slice/ConnectToWifiHandler.java +++ b/src/com/android/settings/wifi/slice/ConnectToWifiHandler.java @@ -22,6 +22,7 @@ import android.os.Bundle; import androidx.annotation.VisibleForTesting; +import com.android.settings.wifi.WifiConnectListener; import com.android.settings.wifi.WifiDialogActivity; import com.android.settings.wifi.WifiUtils; import com.android.settingslib.wifi.AccessPoint; @@ -46,9 +47,10 @@ public class ConnectToWifiHandler extends Activity { @VisibleForTesting void connect(AccessPoint accessPoint) { + final WifiConnectListener connectListener = new WifiConnectListener(this); switch (WifiUtils.getConnectingType(accessPoint)) { case WifiUtils.CONNECT_TYPE_OSU_PROVISION: - accessPoint.startOsuProvisioning(null /* listener */); + accessPoint.startOsuProvisioning(connectListener); break; case WifiUtils.CONNECT_TYPE_OPEN_NETWORK: @@ -56,7 +58,7 @@ public class ConnectToWifiHandler extends Activity { case WifiUtils.CONNECT_TYPE_SAVED_NETWORK: final WifiManager wifiManager = getSystemService(WifiManager.class); - wifiManager.connect(accessPoint.getConfig(), null /* listener */); + wifiManager.connect(accessPoint.getConfig(), connectListener); break; } } diff --git a/tests/robotests/src/com/android/settings/wifi/slice/ConnectToWifiHandlerTest.java b/tests/robotests/src/com/android/settings/wifi/slice/ConnectToWifiHandlerTest.java index 24b0b380434..b18102d226d 100644 --- a/tests/robotests/src/com/android/settings/wifi/slice/ConnectToWifiHandlerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/slice/ConnectToWifiHandlerTest.java @@ -18,12 +18,14 @@ package com.android.settings.wifi.slice; import static com.google.common.truth.Truth.assertThat; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import android.net.wifi.WifiConfiguration; import android.net.wifi.WifiConfiguration.NetworkSelectionStatus; +import android.net.wifi.WifiManager; import com.android.settings.testutils.shadow.ShadowConnectivityManager; import com.android.settings.testutils.shadow.ShadowWifiManager; @@ -78,7 +80,7 @@ public class ConnectToWifiHandlerTest { mHandler.connect(mAccessPoint); - verify(mAccessPoint).startOsuProvisioning(null /* listener */); + verify(mAccessPoint).startOsuProvisioning(any(WifiManager.ActionListener.class)); }