diff --git a/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java b/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java index c5e1ccb431a..f20a110f978 100644 --- a/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java +++ b/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java @@ -146,12 +146,6 @@ public abstract class BaseTimeZonePicker extends InstrumentedFragment return false; } - @Override - public int getMetricsCategory() { - // TODO: use a new metrics id? - return MetricsEvent.ZONE_PICKER; - } - public interface OnListItemClickListener { void onListItemClick(int position); } diff --git a/src/com/android/settings/datetime/timezone/FixedOffsetPicker.java b/src/com/android/settings/datetime/timezone/FixedOffsetPicker.java index 3d8b826a73d..f134051cf63 100644 --- a/src/com/android/settings/datetime/timezone/FixedOffsetPicker.java +++ b/src/com/android/settings/datetime/timezone/FixedOffsetPicker.java @@ -18,6 +18,7 @@ package com.android.settings.datetime.timezone; import android.icu.util.TimeZone; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.datetime.timezone.model.TimeZoneData; @@ -42,6 +43,11 @@ public class FixedOffsetPicker extends BaseTimeZoneInfoPicker { R.string.search_settings, false, false); } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_ZONE_PICKER_FIXED_OFFSET; + } + @Override public List getAllTimeZoneInfos(TimeZoneData timeZoneData) { return loadFixedOffsets(); diff --git a/src/com/android/settings/datetime/timezone/RegionSearchPicker.java b/src/com/android/settings/datetime/timezone/RegionSearchPicker.java index 1381b209feb..859b85184a7 100644 --- a/src/com/android/settings/datetime/timezone/RegionSearchPicker.java +++ b/src/com/android/settings/datetime/timezone/RegionSearchPicker.java @@ -24,6 +24,7 @@ import android.icu.text.LocaleDisplayNames; import android.os.Bundle; import android.util.Log; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.core.SubSettingLauncher; import com.android.settings.datetime.timezone.model.FilteredCountryTimeZones; @@ -49,6 +50,11 @@ public class RegionSearchPicker extends BaseTimeZonePicker { super(R.string.date_time_select_region, R.string.search_settings, true, true); } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_ZONE_PICKER_REGION; + } + @Override protected BaseTimeZoneAdapter createAdapter(TimeZoneData timeZoneData) { mTimeZoneData = timeZoneData; diff --git a/src/com/android/settings/datetime/timezone/RegionZonePicker.java b/src/com/android/settings/datetime/timezone/RegionZonePicker.java index 7805241aec8..37365a8a738 100644 --- a/src/com/android/settings/datetime/timezone/RegionZonePicker.java +++ b/src/com/android/settings/datetime/timezone/RegionZonePicker.java @@ -22,6 +22,7 @@ import android.icu.util.TimeZone; import android.support.annotation.VisibleForTesting; import android.util.Log; +import com.android.internal.logging.nano.MetricsProto; import com.android.settings.R; import com.android.settings.datetime.timezone.model.FilteredCountryTimeZones; import com.android.settings.datetime.timezone.model.TimeZoneData; @@ -46,6 +47,11 @@ public class RegionZonePicker extends BaseTimeZoneInfoPicker { super(R.string.date_time_select_zone, R.string.search_settings, true, false); } + @Override + public int getMetricsCategory() { + return MetricsProto.MetricsEvent.SETTINGS_ZONE_PICKER_TIME_ZONE; + } + /** * Add the extra region id into the result. */ diff --git a/tests/robotests/src/com/android/settings/datetime/timezone/BaseTimeZoneInfoPickerTest.java b/tests/robotests/src/com/android/settings/datetime/timezone/BaseTimeZoneInfoPickerTest.java index 0d47a3a9144..3491b03b32d 100644 --- a/tests/robotests/src/com/android/settings/datetime/timezone/BaseTimeZoneInfoPickerTest.java +++ b/tests/robotests/src/com/android/settings/datetime/timezone/BaseTimeZoneInfoPickerTest.java @@ -119,5 +119,11 @@ public class BaseTimeZoneInfoPickerTest { public Context getContext() { return RuntimeEnvironment.application; } + + @Override + public int getMetricsCategory() { + // the metric id doesn't matter in test + return 1; + } } }