PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ToA]Cache system gender to reduce unnecessary IPC

Browse Source 
Bug: 312324895
Test: atest TermsOfAddressNotSpecifiedControllerTest
atest TermsOfAddressNeutralControllerTest
atest TermsOfAddressMasculineControllerTest
atest TermsOfAddressFeminineControllerTest

Change-Id: Idee2cc1ece673092c94307b8812f032f7826c16a
This commit is contained in:
Allen Su
2024-03-22 03:50:04 +00:00
parent 9c50f2c61d
commit ab18169773
7 changed files with 87 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/src/com/android/settings/localepicker/TermsOfAddressFeminineControllerTest.java
View File

@@ -18,8 +18,6 @@ package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.spy;
import android.app.GrammaticalInflectionManager;
@@ -27,16 +25,14 @@ import android.content.Context;
import android.content.res.Configuration;
import android.os.Looper;
import com.android.settings.widget.TickButtonPreference;
import androidx.preference.PreferenceManager;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.After;
import com.android.settings.widget.TickButtonPreference;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -91,6 +87,7 @@ public class TermsOfAddressFeminineControllerTest {
mPreferenceScreen.addPreference(mMasculinePreference);
mPreferenceScreen.addPreference(mNeutralPreference);
mController = new TermsOfAddressFeminineController(mContext, KEY_FEMININE);
mController.setTermsOfAddressHelper(new TermsOfAddressHelper(mContext));
mController.displayPreference(mPreferenceScreen);
}

11
tests/unit/src/com/android/settings/localepicker/TermsOfAddressMasculineControllerTest.java
View File

@@ -18,8 +18,6 @@ package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.spy;
import android.app.GrammaticalInflectionManager;
@@ -27,16 +25,14 @@ import android.content.Context;
import android.content.res.Configuration;
import android.os.Looper;
import com.android.settings.widget.TickButtonPreference;
import androidx.preference.PreferenceManager;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.After;
import com.android.settings.widget.TickButtonPreference;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -91,6 +87,7 @@ public class TermsOfAddressMasculineControllerTest {
mPreferenceScreen.addPreference(mMasculinePreference);
mPreferenceScreen.addPreference(mNeutralPreference);
mController = new TermsOfAddressMasculineController(mContext, KEY_MASCULINE);
mController.setTermsOfAddressHelper(new TermsOfAddressHelper(mContext));
mController.displayPreference(mPreferenceScreen);
}

13
tests/unit/src/com/android/settings/localepicker/TermsOfAddressNeutralControllerTest.java
View File

@@ -18,8 +18,6 @@ package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.spy;
import android.app.GrammaticalInflectionManager;
@@ -27,16 +25,14 @@ import android.content.Context;
import android.content.res.Configuration;
import android.os.Looper;
import com.android.settings.widget.TickButtonPreference;
import androidx.preference.PreferenceManager;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.After;
import com.android.settings.widget.TickButtonPreference;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -91,11 +87,12 @@ public class TermsOfAddressNeutralControllerTest {
mPreferenceScreen.addPreference(mMasculinePreference);
mPreferenceScreen.addPreference(mNeutralPreference);
mController = new TermsOfAddressNeutralController(mContext, KEY_NEUTRAL);
mController.setTermsOfAddressHelper(new TermsOfAddressHelper(mContext));
mController.displayPreference(mPreferenceScreen);
}
@Test
public void displayPreference_setGrammaticalGenderIsNotSpecified_NotSpecifiedIsSelected() {
public void displayPreference_setGrammaticalGenderIsNotSpecified_NeutralIsSelected() {
TickButtonPreference selectedPreference =
(TickButtonPreference) mPreferenceScreen.getPreference(4);
selectedPreference.performClick();

11
tests/unit/src/com/android/settings/localepicker/TermsOfAddressNotSpecifiedControllerTest.java
View File

@@ -18,8 +18,6 @@ package com.android.settings.localepicker;
import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.spy;
import android.app.GrammaticalInflectionManager;
@@ -27,16 +25,14 @@ import android.content.Context;
import android.content.res.Configuration;
import android.os.Looper;
import com.android.settings.widget.TickButtonPreference;
import androidx.preference.PreferenceManager;
import androidx.preference.Preference;
import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.After;
import com.android.settings.widget.TickButtonPreference;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -91,6 +87,7 @@ public class TermsOfAddressNotSpecifiedControllerTest {
mPreferenceScreen.addPreference(mMasculinePreference);
mPreferenceScreen.addPreference(mNeutralPreference);
mController = new TermsOfAddressNotSpecifiedController(mContext, KEY_NOT_SPECIFIED);
mController.setTermsOfAddressHelper(new TermsOfAddressHelper(mContext));
mController.displayPreference(mPreferenceScreen);
}