PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ToA]Cache system gender to reduce unnecessary IPC

Browse Source 
Bug: 312324895
Test: atest TermsOfAddressNotSpecifiedControllerTest
atest TermsOfAddressNeutralControllerTest
atest TermsOfAddressMasculineControllerTest
atest TermsOfAddressFeminineControllerTest

Change-Id: Idee2cc1ece673092c94307b8812f032f7826c16a
This commit is contained in:
Allen Su
2024-03-22 03:50:04 +00:00
parent 9c50f2c61d
commit ab18169773
7 changed files with 87 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/com/android/settings/localepicker/TermsOfAddressBaseController.java
View File

@@ -16,9 +16,9 @@
package com.android.settings.localepicker;
import android.app.GrammaticalInflectionManager;
import android.content.Context;
import androidx.annotation.NonNull;
import androidx.preference.PreferenceScreen;
import com.android.settings.core.BasePreferenceController;
@@ -35,13 +35,15 @@ public abstract class TermsOfAddressBaseController extends BasePreferenceControl
private PreferenceScreen mPreferenceScreen;
private MetricsFeatureProvider mMetricsFeatureProvider;
private TickButtonPreference mPreference;
private GrammaticalInflectionManager mGrammaticalInflectionManager;
private TermsOfAddressHelper mTermsOfAddressHelper;
public TermsOfAddressBaseController(Context context, String preferenceKey) {
super(context, preferenceKey);
mMetricsFeatureProvider = FeatureFactory.getFeatureFactory().getMetricsFeatureProvider();
mGrammaticalInflectionManager = context.getSystemService(
GrammaticalInflectionManager.class);
}
public void setTermsOfAddressHelper(@NonNull TermsOfAddressHelper termsOfAddressHelper) {
mTermsOfAddressHelper = termsOfAddressHelper;
}
@Override
@@ -52,7 +54,7 @@ public abstract class TermsOfAddressBaseController extends BasePreferenceControl
mPreference.setOnPreferenceClickListener(clickedPref -> {
sExecutor.execute(
() -> {
mGrammaticalInflectionManager.setSystemWideGrammaticalGender(
mTermsOfAddressHelper.setSystemGrammaticalGender(
getGrammaticalGenderType());
});
setSelected(mPreference);
@@ -74,8 +76,7 @@ public abstract class TermsOfAddressBaseController extends BasePreferenceControl
return;
}
mPreference.setSelected(
mGrammaticalInflectionManager.getSystemGrammaticalGender()
== getGrammaticalGenderType());
mTermsOfAddressHelper.getSystemGrammaticalGender() == getGrammaticalGenderType());
}
@Override