From aa5a8a6a4c2e8d7ef9777b1aa69aa10501162104 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Mon, 6 Jun 2016 16:39:55 -0400 Subject: [PATCH 1/3] Fix data usage format strings Bug: 28747101 Change-Id: I5be9bb7ce3b11709117da698d6c03610f4e5e40e --- res/values/strings.xml | 6 +++--- src/com/android/settings/datausage/DataUsageSummary.java | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index ad4c670c11b..41c2dfda887 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -7238,13 +7238,13 @@ Ethernet - %1$s cellular data + ^1 ^2 cellular data - %1$s Wi-Fi data + ^1 ^2 Wi-Fi data - %1$s ethernet data + ^1 ^2 ethernet data %1$s Data warning diff --git a/src/com/android/settings/datausage/DataUsageSummary.java b/src/com/android/settings/datausage/DataUsageSummary.java index bd6ae5c9fc1..51804c132de 100644 --- a/src/com/android/settings/datausage/DataUsageSummary.java +++ b/src/com/android/settings/datausage/DataUsageSummary.java @@ -32,6 +32,7 @@ import android.support.v7.preference.PreferenceScreen; import android.telephony.SubscriptionInfo; import android.telephony.SubscriptionManager; import android.telephony.TelephonyManager; +import android.text.TextUtils; import android.text.format.Formatter; import android.view.Menu; import android.view.MenuInflater; @@ -189,8 +190,8 @@ public class DataUsageSummary extends DataUsageBase implements Indexable { if (mSummaryPreference != null) { Formatter.BytesResult usedResult = Formatter.formatBytes(context.getResources(), info.usageLevel, Formatter.FLAG_SHORTER); - mSummaryPreference.setAmount(usedResult.value); - mSummaryPreference.setUnits(getString(mDataUsageTemplate, usedResult.units)); + mSummaryPreference.setTitle(TextUtils.expandTemplate(getText(mDataUsageTemplate), + usedResult.value, usedResult.units)); long limit = info.limitLevel; if (limit <= 0) { limit = info.warningLevel; From 5862c1ef02ebb6c23b30d470913dac508700cb53 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Tue, 7 Jun 2016 14:02:33 -0400 Subject: [PATCH 2/3] Fix disabling of tiles that are not relevant - Fix restricted user tiles being disabled - Call new better method in SettingsDrawerActivity for disabling Change-Id: I2fb6ddd3d505189d2b6d96c0a1039291b80a2f70 Fixes: 29080209 --- AndroidManifest.xml | 7 ++----- src/com/android/settings/SettingsActivity.java | 13 +++---------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index e8271a8e4c2..a686a7ac95a 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -1896,8 +1896,7 @@ android:label="@string/development_settings_title" android:icon="@drawable/ic_settings_development" android:taskAffinity="com.android.settings" - android:parentActivityName="Settings" - android:enabled="false"> + android:parentActivityName="Settings"> @@ -2442,8 +2441,7 @@ + android:taskAffinity=""> @@ -2728,7 +2726,6 @@ diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index d989535cf28..9a9dfee3f56 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -1080,7 +1080,7 @@ public class SettingsActivity extends SettingsDrawerActivity for (DashboardCategory category : categories) { for (Tile tile : category.tiles) { ComponentName component = tile.intent.getComponent(); - if (packageName.equals(component)&& !ArrayUtils.contains( + if (packageName.equals(component.getPackageName()) && !ArrayUtils.contains( SETTINGS_FOR_RESTRICTED, component.getClassName())) { setTileEnabled(component, false, isAdmin, pm); } @@ -1091,18 +1091,11 @@ public class SettingsActivity extends SettingsDrawerActivity private void setTileEnabled(ComponentName component, boolean enabled, boolean isAdmin, PackageManager pm) { - if (UserHandle.MU_ENABLED && !isAdmin + if (UserHandle.MU_ENABLED && !isAdmin && getPackageName().equals(component.getPackageName()) && !ArrayUtils.contains(SETTINGS_FOR_RESTRICTED, component.getClassName())) { enabled = false; } - int state = pm.getComponentEnabledSetting(component); - boolean isEnabled = state == PackageManager.COMPONENT_ENABLED_STATE_ENABLED; - if (isEnabled != enabled) { - pm.setComponentEnabledSetting(component, enabled - ? PackageManager.COMPONENT_ENABLED_STATE_ENABLED - : PackageManager.COMPONENT_ENABLED_STATE_DISABLED, - PackageManager.DONT_KILL_APP); - } + setTileEnabled(component, enabled); } private void getMetaData() { From b7e4380cd27ffd8a060ecb61201057fb6843e408 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Mon, 6 Jun 2016 16:01:58 -0400 Subject: [PATCH 3/3] Remove PreferenceActivity Its broken and isn't worth maintaining, instead port the few things using it over to SettingsPreferenceActivity with wrapping blank Activities like the rest of Settings. Change-Id: Ic82f0dcb63ed9b4078f7da6a79c0c52f0130e8d1 Fixes: 28779941 --- AndroidManifest.xml | 39 ++++++--- res/layout/icc_lock_tabs.xml | 2 +- res/xml/device_info_settings.xml | 2 +- res/xml/device_info_status.xml | 4 +- res/xml/security_settings_misc.xml | 2 +- res/xml/testing_settings.xml | 2 +- res/xml/testing_wifi_settings.xml | 2 +- src/com/android/settings/ApnEditor.java | 86 ++++++++++--------- src/com/android/settings/IccLockSettings.java | 66 ++++++++------ .../InstrumentedPreferenceActivity.java | 45 ---------- .../android/settings/PreferenceActivity.java | 82 ------------------ src/com/android/settings/Settings.java | 10 +++ .../android/settings/SettingsActivity.java | 15 ++++ .../settings/SettingsPreferenceFragment.java | 27 +++++- src/com/android/settings/TestingSettings.java | 12 ++- .../TestingSettingsBroadcastReceiver.java | 4 +- .../settings/accounts/AddAccountSettings.java | 3 +- .../accounts/ChooseAccountActivity.java | 33 +++---- .../settings/deviceinfo/ImeiInformation.java | 8 +- .../settings/deviceinfo/SimStatus.java | 51 +++++++---- .../android/settings/deviceinfo/Status.java | 24 +++--- .../android/settings/wifi/WifiAPITest.java | 29 ++++--- src/com/android/settings/wifi/WifiInfo.java | 11 ++- 23 files changed, 282 insertions(+), 277 deletions(-) delete mode 100644 src/com/android/settings/InstrumentedPreferenceActivity.java delete mode 100644 src/com/android/settings/PreferenceActivity.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index e8271a8e4c2..5cde21c11a2 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -327,7 +327,7 @@ android:value="true" /> - @@ -336,6 +336,8 @@ + - + - @@ -1457,6 +1461,8 @@ + - @@ -1748,10 +1754,12 @@ + - @@ -1760,10 +1768,12 @@ + - @@ -1772,6 +1782,8 @@ + - @@ -1890,6 +1902,8 @@ + - + + @@ -2319,10 +2335,13 @@ android:value="true" /> - + android:theme="@style/Theme.SubSettingsDialogWhenLarge"> + + + android:targetClass="com.android.settings.Settings$StatusActivity" /> diff --git a/res/xml/device_info_status.xml b/res/xml/device_info_status.xml index 2cb5c6d736f..a0b7590509e 100644 --- a/res/xml/device_info_status.xml +++ b/res/xml/device_info_status.xml @@ -33,13 +33,13 @@ android:title="@string/sim_status_title" android:persistent="false"> + android:targetClass="com.android.settings.Settings$SimStatusActivity" /> + android:targetClass="com.android.settings.Settings$ImeiInformationActivity" /> + android:targetClass="com.android.settings.Settings$IccLockSettingsActivity"/> diff --git a/res/xml/testing_settings.xml b/res/xml/testing_settings.xml index 4e5c5ddf284..bce03e5aa06 100644 --- a/res/xml/testing_settings.xml +++ b/res/xml/testing_settings.xml @@ -37,7 +37,7 @@ + android:targetClass="com.android.settings.Settings$WifiInfoActivity" />