Merge "[Settings] Refactor DataUsageSummaryPreferenceController"

This commit is contained in:
Bonian Chen
2020-03-13 12:08:30 +00:00
committed by Gerrit Code Review

View File

@@ -40,6 +40,7 @@ import com.android.internal.util.CollectionUtils;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.network.ProxySubscriptionManager;
import com.android.settings.widget.EntityHeaderController; import com.android.settings.widget.EntityHeaderController;
import com.android.settingslib.NetworkPolicyEditor; import com.android.settingslib.NetworkPolicyEditor;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
@@ -117,8 +118,8 @@ public class DataUsageSummaryPreferenceController extends BasePreferenceControll
NetworkPolicyManager policyManager = activity.getSystemService(NetworkPolicyManager.class); NetworkPolicyManager policyManager = activity.getSystemService(NetworkPolicyManager.class);
mPolicyEditor = new NetworkPolicyEditor(policyManager); mPolicyEditor = new NetworkPolicyEditor(policyManager);
mHasMobileData = DataUsageUtils.hasMobileData(activity) mHasMobileData = SubscriptionManager.isValidSubscriptionId(mSubscriptionId)
&& mSubscriptionId != SubscriptionManager.INVALID_SUBSCRIPTION_ID; && DataUsageUtils.hasMobileData(activity);
mDataUsageController = new DataUsageController(activity); mDataUsageController = new DataUsageController(activity);
mDataUsageController.setSubscriptionId(mSubscriptionId); mDataUsageController.setSubscriptionId(mSubscriptionId);
@@ -270,11 +271,10 @@ public class DataUsageSummaryPreferenceController extends BasePreferenceControll
mCycleEnd = info.cycleEnd; mCycleEnd = info.cycleEnd;
mSnapshotTime = -1L; mSnapshotTime = -1L;
SubscriptionInfo subInfo = mSubscriptionManager.getActiveSubscriptionInfo(mSubscriptionId); final ProxySubscriptionManager proxySubsciptionMgr =
if (subInfo == null) { ProxySubscriptionManager.getInstance(mContext);
subInfo = mSubscriptionManager.getAllSubscriptionInfoList().stream().filter( final SubscriptionInfo subInfo = proxySubsciptionMgr
i -> i.getSubscriptionId() == mSubscriptionId).findFirst().orElse(null); .getAccessibleSubscriptionInfo(mSubscriptionId);
}
if (subInfo != null && mHasMobileData) { if (subInfo != null && mHasMobileData) {
mCarrierName = subInfo.getCarrierName(); mCarrierName = subInfo.getCarrierName();
List<SubscriptionPlan> plans = mSubscriptionManager.getSubscriptionPlans( List<SubscriptionPlan> plans = mSubscriptionManager.getSubscriptionPlans(