From a9fb15230934b8a12e6ca8d14907a4813d8cff3c Mon Sep 17 00:00:00 2001 From: "Philip P. Moltmann" Date: Thu, 31 Jan 2019 14:22:24 -0800 Subject: [PATCH] Flags instead of booleans for countPermissionApps Test: Checked that the api retunred the results Bug: 123697839 Change-Id: Iadb1c4307933635e6114d3d32a2a2b1ed87949f4 --- .../location/AppLocationPermissionPreferenceController.java | 5 +++-- .../location/TopLevelLocationPreferenceController.java | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/location/AppLocationPermissionPreferenceController.java b/src/com/android/settings/location/AppLocationPermissionPreferenceController.java index 1fd19860659..43a6a9b26de 100644 --- a/src/com/android/settings/location/AppLocationPermissionPreferenceController.java +++ b/src/com/android/settings/location/AppLocationPermissionPreferenceController.java @@ -76,7 +76,7 @@ public class AppLocationPermissionPreferenceController extends PermissionControllerManager permController = mContext.getSystemService(PermissionControllerManager.class); permController.countPermissionApps( - Arrays.asList(ACCESS_FINE_LOCATION, ACCESS_COARSE_LOCATION), false, false, + Arrays.asList(ACCESS_FINE_LOCATION, ACCESS_COARSE_LOCATION), 0, (numApps) -> { mNumTotal = numApps; if (loadingInProgress.decrementAndGet() == 0) { @@ -85,7 +85,8 @@ public class AppLocationPermissionPreferenceController extends }, null); permController.countPermissionApps( - Collections.singletonList(ACCESS_BACKGROUND_LOCATION), true, false, + Collections.singletonList(ACCESS_BACKGROUND_LOCATION), + PermissionControllerManager.COUNT_ONLY_WHEN_GRANTED, (numApps) -> { mNumBackground = numApps; if (loadingInProgress.decrementAndGet() == 0) { diff --git a/src/com/android/settings/location/TopLevelLocationPreferenceController.java b/src/com/android/settings/location/TopLevelLocationPreferenceController.java index 6d7789fe4fe..2a7a3d7de2d 100644 --- a/src/com/android/settings/location/TopLevelLocationPreferenceController.java +++ b/src/com/android/settings/location/TopLevelLocationPreferenceController.java @@ -71,7 +71,7 @@ public class TopLevelLocationPreferenceController extends BasePreferenceControll return; } mContext.getSystemService(PermissionControllerManager.class).countPermissionApps( - Arrays.asList(ACCESS_FINE_LOCATION, ACCESS_COARSE_LOCATION), false, false, + Arrays.asList(ACCESS_FINE_LOCATION, ACCESS_COARSE_LOCATION), 0, (numApps) -> { setLocationAppCount(numApps); }, null);