Merge "Make "Battery usage" accessible at any time" into oc-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
a935b3c030
@@ -196,6 +196,8 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
BatterySipper mSipper;
|
||||
@VisibleForTesting
|
||||
BatteryStatsHelper mBatteryHelper;
|
||||
@VisibleForTesting
|
||||
BatteryUtils mBatteryUtils;
|
||||
|
||||
protected ProcStatsData mStatsManager;
|
||||
protected ProcStatsPackageEntry mStats;
|
||||
@@ -204,7 +206,6 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
|
||||
private AppStorageStats mLastResult;
|
||||
private String mBatteryPercent;
|
||||
private BatteryUtils mBatteryUtils;
|
||||
|
||||
private final LoaderCallbacks<BatteryStatsHelper> mBatteryCallbacks =
|
||||
new LoaderCallbacks<BatteryStatsHelper>() {
|
||||
@@ -729,8 +730,6 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
mDataPreference.setSummary(getDataSummary());
|
||||
}
|
||||
|
||||
updateBattery();
|
||||
|
||||
if (!mInitialized) {
|
||||
// First time init: are we displaying an uninstalled app?
|
||||
mInitialized = true;
|
||||
@@ -757,9 +756,10 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
return true;
|
||||
}
|
||||
|
||||
private void updateBattery() {
|
||||
if (mSipper != null && mBatteryHelper != null) {
|
||||
mBatteryPreference.setEnabled(true);
|
||||
@VisibleForTesting
|
||||
void updateBattery() {
|
||||
mBatteryPreference.setEnabled(true);
|
||||
if (isBatteryStatsAvailable()) {
|
||||
final int dischargeAmount = mBatteryHelper.getStats().getDischargeAmount(
|
||||
BatteryStats.STATS_SINCE_CHARGED);
|
||||
|
||||
@@ -771,7 +771,6 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
mBatteryPercent = Utils.formatPercentage(percentOfMax);
|
||||
mBatteryPreference.setSummary(getString(R.string.battery_summary, mBatteryPercent));
|
||||
} else {
|
||||
mBatteryPreference.setEnabled(false);
|
||||
mBatteryPreference.setSummary(getString(R.string.no_battery_summary));
|
||||
}
|
||||
}
|
||||
@@ -805,6 +804,11 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
}
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
boolean isBatteryStatsAvailable() {
|
||||
return mBatteryHelper != null && mSipper != null;
|
||||
}
|
||||
|
||||
private static CharSequence getSize(Context context, AppStorageStats stats) {
|
||||
return Formatter.formatFileSize(context, stats.getTotalBytes());
|
||||
}
|
||||
@@ -1043,9 +1047,15 @@ public class InstalledAppDetails extends AppInfoBase
|
||||
} else if (preference == mDataPreference) {
|
||||
startAppInfoFragment(AppDataUsage.class, getString(R.string.app_data_usage));
|
||||
} else if (preference == mBatteryPreference) {
|
||||
BatteryEntry entry = new BatteryEntry(getContext(), null, mUserManager, mSipper);
|
||||
AdvancedPowerUsageDetail.startBatteryDetailPage((SettingsActivity) getActivity(), this,
|
||||
mBatteryHelper, BatteryStats.STATS_SINCE_CHARGED, entry, mBatteryPercent);
|
||||
if (isBatteryStatsAvailable()) {
|
||||
BatteryEntry entry = new BatteryEntry(getContext(), null, mUserManager, mSipper);
|
||||
AdvancedPowerUsageDetail.startBatteryDetailPage((SettingsActivity) getActivity(),
|
||||
this, mBatteryHelper, BatteryStats.STATS_SINCE_CHARGED, entry,
|
||||
mBatteryPercent);
|
||||
} else {
|
||||
AdvancedPowerUsageDetail.startBatteryDetailPage((SettingsActivity) getActivity(),
|
||||
this, mPackageName);
|
||||
}
|
||||
} else {
|
||||
return false;
|
||||
}
|
||||
|
@@ -133,6 +133,16 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
|
||||
new UserHandle(UserHandle.getUserId(sipper.getUid())));
|
||||
}
|
||||
|
||||
public static void startBatteryDetailPage(SettingsActivity caller, PreferenceFragment fragment,
|
||||
String packageName) {
|
||||
final Bundle args = new Bundle(2);
|
||||
args.putString(EXTRA_PACKAGE_NAME, packageName);
|
||||
args.putString(EXTRA_POWER_USAGE_PERCENT, Utils.formatPercentage(0));
|
||||
|
||||
caller.startPreferencePanelAsUser(fragment, AdvancedPowerUsageDetail.class.getName(), args,
|
||||
R.string.battery_details_title, null, new UserHandle(UserHandle.myUserId()));
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onAttach(Activity activity) {
|
||||
super.onAttach(activity);
|
||||
|
Reference in New Issue
Block a user