PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash when input illegal proxy port number

Browse Source 
Bug: 253951250
Test: manual and atest
Change-Id: I80d2f0e3ce2df86a081b29d8633e06cfc648baeb
This commit is contained in:
Shen Lin
2022-10-17 13:06:07 +08:00
parent df8e9c630a
commit a911e61ce7
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/com/android/settings/vpn2/ConfigDialog.java
View File

@@ -626,7 +626,14 @@ class ConfigDialog extends AlertDialog implements TextWatcher,
String proxyPort = mProxyPort.getText().toString().trim(); String proxyPort = mProxyPort.getText().toString().trim();
// 0 is a last resort default, but the interface validates that the proxy port is // 0 is a last resort default, but the interface validates that the proxy port is
// present and non-zero. // present and non-zero.
int port = proxyPort.isEmpty() ? 0 : Integer.parseInt(proxyPort); int port = 0;
if (!proxyPort.isEmpty()) {
try {
port = Integer.parseInt(proxyPort);
} catch (NumberFormatException e) {
Log.e(TAG, "Could not parse proxy port integer ", e);
}
}
profile.proxy = ProxyInfo.buildDirectProxy(proxyHost, port); profile.proxy = ProxyInfo.buildDirectProxy(proxyHost, port);
} else { } else {
profile.proxy = null; profile.proxy = null;