From a8e5e217d58435c3f196e04e4e2097716c51d0fc Mon Sep 17 00:00:00 2001
From: Andreas Gampe <agampe@google.com>
Date: Thu, 22 Feb 2018 21:54:07 -0800
Subject: [PATCH] Settings: Change an assert in test

Avoid isEqualsTo for a self-equality test.

Bug: 73797873
Test: m javac-check RUN_ERROR_PRONE=true
Test: m RunSettingsRoboTests
Change-Id: I6f0398b4518d6c967c8cfea38b5c075304b5f368
---
 .../applications/manageapplications/AppFilterItemTest.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/robotests/src/com/android/settings/applications/manageapplications/AppFilterItemTest.java b/tests/robotests/src/com/android/settings/applications/manageapplications/AppFilterItemTest.java
index 982fb564756..7e19d573e03 100644
--- a/tests/robotests/src/com/android/settings/applications/manageapplications/AppFilterItemTest.java
+++ b/tests/robotests/src/com/android/settings/applications/manageapplications/AppFilterItemTest.java
@@ -47,7 +47,8 @@ public class AppFilterItemTest {
                 R.string.filter_all_apps);
 
         // Same instance, should be same
-        assertThat(item).isEqualTo(item);
+        // (Use isTrue as isEqualsTo will prioritize reference equality!)
+        assertThat(item.equals(item)).isTrue();
 
         // Same content, should be same
         assertThat(item).isEqualTo(item2);