From a8ae717599ffe887308cc6f6aa227cbb0b75a320 Mon Sep 17 00:00:00 2001 From: jeffreyhuang Date: Thu, 12 Oct 2017 12:28:32 -0700 Subject: [PATCH] Introduce BackgroundProcessLimitPreferenceCtrl - Create new BackgroundProcessLimitPreferenceController - Create controller inside the DashboardFragment - Port logic from DevelopmentSettings into the controller Bug: 34203528 Test: make RunSettingsRoboTests -j40 Change-Id: Ie151f911917ecf9401df8f3daa6f10770b7a571e --- ...roundProcessLimitPreferenceController.java | 116 ++++++++++++++ .../DevelopmentSettingsDashboardFragment.java | 2 +- ...dProcessLimitPreferenceControllerTest.java | 141 ++++++++++++++++++ 3 files changed, 258 insertions(+), 1 deletion(-) create mode 100644 src/com/android/settings/development/BackgroundProcessLimitPreferenceController.java create mode 100644 tests/robotests/src/com/android/settings/development/BackgroundProcessLimitPreferenceControllerTest.java diff --git a/src/com/android/settings/development/BackgroundProcessLimitPreferenceController.java b/src/com/android/settings/development/BackgroundProcessLimitPreferenceController.java new file mode 100644 index 00000000000..9f962ca1371 --- /dev/null +++ b/src/com/android/settings/development/BackgroundProcessLimitPreferenceController.java @@ -0,0 +1,116 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.development; + +import android.app.ActivityManager; +import android.app.IActivityManager; +import android.content.Context; +import android.os.RemoteException; +import android.support.annotation.VisibleForTesting; +import android.support.v7.preference.ListPreference; +import android.support.v7.preference.Preference; +import android.support.v7.preference.PreferenceScreen; + +import com.android.settings.R; +import com.android.settings.core.PreferenceControllerMixin; +import com.android.settingslib.development.DeveloperOptionsPreferenceController; + +public class BackgroundProcessLimitPreferenceController extends + DeveloperOptionsPreferenceController implements Preference.OnPreferenceChangeListener, + PreferenceControllerMixin { + + private static final String APP_PROCESS_LIMIT_KEY = "app_process_limit"; + + private final String[] mListValues; + private final String[] mListSummaries; + private ListPreference mPreference; + + public BackgroundProcessLimitPreferenceController(Context context) { + super(context); + + mListValues = context.getResources().getStringArray(R.array.app_process_limit_values); + mListSummaries = context.getResources().getStringArray(R.array.app_process_limit_entries); + } + + @Override + public String getPreferenceKey() { + return APP_PROCESS_LIMIT_KEY; + } + + @Override + public void displayPreference(PreferenceScreen screen) { + super.displayPreference(screen); + + mPreference = (ListPreference) screen.findPreference(getPreferenceKey()); + } + + @Override + public boolean onPreferenceChange(Preference preference, Object newValue) { + writeAppProcessLimitOptions(newValue); + updateAppProcessLimitOptions(); + return true; + } + + @Override + public void updateState(Preference preference) { + updateAppProcessLimitOptions(); + } + + @Override + protected void onDeveloperOptionsSwitchEnabled() { + mPreference.setEnabled(true); + } + + @Override + protected void onDeveloperOptionsSwitchDisabled() { + writeAppProcessLimitOptions(null); + mPreference.setEnabled(false); + } + + private void updateAppProcessLimitOptions() { + try { + final int limit = getActivityManagerService().getProcessLimit(); + int index = 0; // default + for (int i = 0; i < mListValues.length; i++) { + int val = Integer.parseInt(mListValues[i]); + if (val >= limit) { + index = i; + break; + } + } + mPreference.setValue(mListValues[index]); + mPreference.setSummary(mListSummaries[index]); + } catch (RemoteException e) { + // intentional no-op + } + } + + private void writeAppProcessLimitOptions(Object newValue) { + try { + final int limit = newValue != null ? Integer.parseInt(newValue.toString()) : -1; + getActivityManagerService().setProcessLimit(limit); + updateAppProcessLimitOptions(); + } catch (RemoteException e) { + // intentional no-op + } + } + + @VisibleForTesting + IActivityManager getActivityManagerService() { + return ActivityManager.getService(); + } +} diff --git a/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java b/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java index 8c56ebb0ed3..07229661c2e 100644 --- a/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java +++ b/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java @@ -404,7 +404,7 @@ public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFra controllers.add(new StrictModePreferenceController(context)); // profile gpu rendering controllers.add(new KeepActivitiesPreferenceController(context)); - // background process limit + controllers.add(new BackgroundProcessLimitPreferenceController(context)); // background check controllers.add(new AppsNotRespondingPreferenceController(context)); controllers.add(new NotificationChannelWarningsPreferenceController(context)); diff --git a/tests/robotests/src/com/android/settings/development/BackgroundProcessLimitPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/BackgroundProcessLimitPreferenceControllerTest.java new file mode 100644 index 00000000000..b384cd06c2d --- /dev/null +++ b/tests/robotests/src/com/android/settings/development/BackgroundProcessLimitPreferenceControllerTest.java @@ -0,0 +1,141 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.development; + +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.spy; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import android.app.IActivityManager; +import android.content.Context; +import android.os.RemoteException; +import android.support.v7.preference.ListPreference; +import android.support.v7.preference.PreferenceScreen; + +import com.android.settings.R; +import com.android.settings.TestConfig; +import com.android.settings.testutils.SettingsRobolectricTestRunner; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; + +@RunWith(SettingsRobolectricTestRunner.class) +@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION) +public class BackgroundProcessLimitPreferenceControllerTest { + + @Mock + private IActivityManager mActivityManager; + @Mock + private ListPreference mPreference; + @Mock + private PreferenceScreen mScreen; + + /** + * 0: Standard limit + * 1: No Background processes + * 2: At most 1 process + * 3: At most 2 processes + * 4: At most 3 processes + * 5: At most 4 processes + */ + private String[] mListValues; + private String[] mListSummaries; + private Context mContext; + private BackgroundProcessLimitPreferenceController mController; + + @Before + public void setup() { + MockitoAnnotations.initMocks(this); + mContext = RuntimeEnvironment.application; + mListValues = mContext.getResources().getStringArray(R.array.app_process_limit_values); + mListSummaries = mContext.getResources().getStringArray(R.array.app_process_limit_entries); + mController = spy(new BackgroundProcessLimitPreferenceController(mContext)); + doReturn(mActivityManager).when(mController).getActivityManagerService(); + when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); + mController.displayPreference(mScreen); + } + + @Test + public void onPreferenceChange_noBackgroundProcessSet_shouldSetToNoBackgroundProcess() + throws RemoteException { + mController.onPreferenceChange(mPreference, mListValues[1]); + + verify(mActivityManager).setProcessLimit(Integer.valueOf(mListValues[1])); + } + + @Test + public void onPreferenceChange_1ProcessSet_shouldSetTo1BackgroundProcess() + throws RemoteException { + mController.onPreferenceChange(mPreference, mListValues[2]); + + verify(mActivityManager).setProcessLimit(Integer.valueOf(mListValues[2])); + } + + @Test + public void updateState_noBackgroundProcessSet_shouldSetPreferenceToNoBackgroundProcess() + throws RemoteException { + when(mActivityManager.getProcessLimit()).thenReturn(Integer.valueOf(mListValues[1])); + + mController.updateState(mPreference); + + verify(mPreference).setValue(mListValues[1]); + verify(mPreference).setSummary(mListSummaries[1]); + } + + @Test + public void updateState_1ProcessSet_shouldSetPreference1BackgroundProcess() + throws RemoteException { + when(mActivityManager.getProcessLimit()).thenReturn(Integer.valueOf(mListValues[2])); + + mController.updateState(mPreference); + + verify(mPreference).setValue(mListValues[2]); + verify(mPreference).setSummary(mListSummaries[2]); + } + + @Test + public void updateState_veryHighLimit_shouldDefaultToStandardLimit() throws RemoteException { + when(mActivityManager.getProcessLimit()).thenReturn(Integer.MAX_VALUE); + + mController.updateState(mPreference); + + verify(mPreference).setValue(mListValues[0]); + verify(mPreference).setSummary(mListSummaries[0]); + } + + @Test + public void onDeveloperOptionsSwitchEnabled_shouldEnablePreference() { + mController.onDeveloperOptionsSwitchEnabled(); + + verify(mPreference).setEnabled(true); + } + + @Test + public void onDeveloperOptionsSwitchDisabled_shouldDisableAndResetPreference() + throws RemoteException { + mController.onDeveloperOptionsSwitchDisabled(); + + verify(mPreference).setEnabled(false); + verify(mActivityManager).setProcessLimit(-1); + } +}