diff --git a/res/values/arrays.xml b/res/values/arrays.xml index e80d1514d3d..6f336eb0a74 100644 --- a/res/values/arrays.xml +++ b/res/values/arrays.xml @@ -1105,8 +1105,8 @@ - Default (use randomized MAC) - Trusted + Use device MAC + Use randomized MAC (default) diff --git a/res/values/strings.xml b/res/values/strings.xml index c6c066e63c5..f7eedbaaa96 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -10338,9 +10338,9 @@ See less - Choose device + Choose a device - No devices found. Make sure the device is turned on and available to connect. + No devices found. Make sure devices are turned on and available to connect. Try again diff --git a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java index 30c2cd96f16..7a1bdb43f51 100644 --- a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java +++ b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java @@ -16,6 +16,7 @@ package com.android.settings.wifi; +import android.app.Activity; import android.app.Dialog; import android.content.Context; import android.content.DialogInterface; @@ -328,8 +329,12 @@ public class NetworkRequestDialogFragment extends InstrumentedDialogFragment imp @Override public void onUserSelectionConnectSuccess(WifiConfiguration wificonfiguration) { - // Dismisses current dialog, since connection is success. + // Dismisses current dialog and finishes Activity, since connection is success. dismiss(); + final Activity activity = getActivity(); + if (activity != null) { + activity.finish(); + } } @Override diff --git a/tests/robotests/src/com/android/settings/wifi/details/WifiPrivacyPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/details/WifiPrivacyPreferenceControllerTest.java index 8bbb2be7c60..20c58380a0c 100644 --- a/tests/robotests/src/com/android/settings/wifi/details/WifiPrivacyPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/details/WifiPrivacyPreferenceControllerTest.java @@ -38,8 +38,8 @@ import org.robolectric.RuntimeEnvironment; @RunWith(RobolectricTestRunner.class) public class WifiPrivacyPreferenceControllerTest { - private static final int PRIVACY_RANDOMIZED = 0; - private static final int PRIVACY_TRUSTED = 1; + private static final int PRIVACY_RANDOMIZED = WifiConfiguration.RANDOMIZATION_PERSISTENT; + private static final int PRIVACY_TRUSTED = WifiConfiguration.RANDOMIZATION_NONE; @Mock private WifiConfiguration mWifiConfiguration; @@ -47,6 +47,7 @@ public class WifiPrivacyPreferenceControllerTest { private WifiPrivacyPreferenceController mPreferenceController; private Context mContext; private DropDownPreference mDropDownPreference; + private String[] perferenceString; @Before public void setUp() { @@ -59,6 +60,8 @@ public class WifiPrivacyPreferenceControllerTest { mDropDownPreference = new DropDownPreference(mContext); mDropDownPreference.setEntries(R.array.wifi_privacy_entries); mDropDownPreference.setEntryValues(R.array.wifi_privacy_values); + + perferenceString = mContext.getResources().getStringArray(R.array.wifi_privacy_entries); } @Test @@ -67,7 +70,8 @@ public class WifiPrivacyPreferenceControllerTest { mPreferenceController.updateState(mDropDownPreference); - assertThat(mDropDownPreference.getEntry()).isEqualTo("Trusted"); + + assertThat(mDropDownPreference.getEntry()).isEqualTo(perferenceString[PRIVACY_TRUSTED]); } @Test @@ -76,7 +80,7 @@ public class WifiPrivacyPreferenceControllerTest { mPreferenceController.updateState(mDropDownPreference); - assertThat(mDropDownPreference.getEntry()).isEqualTo("Default (use randomized MAC)"); + assertThat(mDropDownPreference.getEntry()).isEqualTo(perferenceString[PRIVACY_RANDOMIZED]); } @Test