Fix field reordering on toggle switch

Every field needs an explicit order.

Test: manual
Change-Id: Iae533db9e9d240bd0dc14da04a1831fe23005f9e
Fixes: 79749266
This commit is contained in:
Julia Reynolds
2018-05-22 09:09:22 -04:00
parent 5c99a41a9c
commit a65cec7b9a

View File

@@ -22,32 +22,38 @@
<com.android.settings.applications.LayoutPreference <com.android.settings.applications.LayoutPreference
android:key="pref_app_header" android:key="pref_app_header"
android:order="1"
android:layout="@layout/settings_entity_header" /> android:layout="@layout/settings_entity_header" />
<com.android.settings.applications.LayoutPreference <com.android.settings.applications.LayoutPreference
android:key="block" android:key="block"
android:order="2"
android:layout="@layout/styled_switch_bar" /> android:layout="@layout/styled_switch_bar" />
<!-- Importance toggle -->
<com.android.settingslib.RestrictedSwitchPreference
android:key="allow_sound"
android:order="3"
android:title="@string/allow_interruption"
android:summary="@string/allow_interruption_summary" />
<!-- Importance -->
<com.android.settings.RestrictedListPreference
android:key="importance"
android:order="10"
android:title="@string/notification_importance_title" />
<PreferenceCategory <PreferenceCategory
android:key="channel_advanced" android:key="channel_advanced"
android:order="50" android:order="50"
settings:initialExpandedChildrenCount="1"> settings:initialExpandedChildrenCount="0">
<!-- Importance -->
<com.android.settings.RestrictedListPreference
android:key="importance"
android:title="@string/notification_importance_title" />
<!-- Importance toggle -->
<com.android.settingslib.RestrictedSwitchPreference
android:key="allow_sound"
android:title="@string/allow_interruption"
android:summary="@string/allow_interruption_summary" />
<!-- Default ringtone --> <!-- Default ringtone -->
<com.android.settings.notification.NotificationSoundPreference <com.android.settings.notification.NotificationSoundPreference
android:key="ringtone" android:key="ringtone"
android:title="@string/notification_channel_sound_title" android:title="@string/notification_channel_sound_title"
android:dialogTitle="@string/notification_channel_sound_title" android:dialogTitle="@string/notification_channel_sound_title"
android:order="11"
android:showSilent="true" android:showSilent="true"
android:showDefault="true" android:showDefault="true"
android:ringtoneType="notification" /> android:ringtoneType="notification" />
@@ -55,23 +61,27 @@
<!-- Vibration --> <!-- Vibration -->
<com.android.settingslib.RestrictedSwitchPreference <com.android.settingslib.RestrictedSwitchPreference
android:key="vibrate" android:key="vibrate"
android:order="12"
android:title="@string/notification_vibrate_title" android:title="@string/notification_vibrate_title"
settings:useAdditionalSummary="true" /> settings:useAdditionalSummary="true" />
<!-- Visibility Override --> <!-- Visibility Override -->
<com.android.settings.RestrictedListPreference <com.android.settings.RestrictedListPreference
android:key="visibility_override" android:key="visibility_override"
android:order="13"
android:title="@string/app_notification_visibility_override_title"/> android:title="@string/app_notification_visibility_override_title"/>
<!-- Lights --> <!-- Lights -->
<com.android.settingslib.RestrictedSwitchPreference <com.android.settingslib.RestrictedSwitchPreference
android:key="lights" android:key="lights"
android:order="14"
android:title="@string/notification_show_lights_title" android:title="@string/notification_show_lights_title"
settings:useAdditionalSummary="true"/> settings:useAdditionalSummary="true"/>
<!-- Show badge --> <!-- Show badge -->
<com.android.settingslib.RestrictedSwitchPreference <com.android.settingslib.RestrictedSwitchPreference
android:key="badge" android:key="badge"
android:order="15"
android:title="@string/notification_channel_badge_title" android:title="@string/notification_channel_badge_title"
settings:useAdditionalSummary="true" settings:useAdditionalSummary="true"
settings:restrictedSwitchSummary="@string/enabled_by_admin"/> settings:restrictedSwitchSummary="@string/enabled_by_admin"/>
@@ -79,12 +89,14 @@
<!-- Bypass DND --> <!-- Bypass DND -->
<com.android.settingslib.RestrictedSwitchPreference <com.android.settingslib.RestrictedSwitchPreference
android:key="bypass_dnd" android:key="bypass_dnd"
android:order="16"
android:title="@string/app_notification_override_dnd_title" android:title="@string/app_notification_override_dnd_title"
android:summary="@string/app_notification_override_dnd_summary" android:summary="@string/app_notification_override_dnd_summary"
settings:useAdditionalSummary="true"/> settings:useAdditionalSummary="true"/>
<Preference <Preference
android:key="app_link" android:key="app_link"
android:order="17"
android:title="@string/app_settings_link" android:title="@string/app_settings_link"
settings:allowDividerAbove="true"/> settings:allowDividerAbove="true"/>
</PreferenceCategory> </PreferenceCategory>