From 011f0dbcdb4cce682905e7e4aa944497811e5885 Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Fri, 21 Oct 2016 10:50:34 -0700 Subject: [PATCH] Add scroll view for choose_lock_pattern in land mode Wrap the title and header with scroll view in case they are too large to display Bug: 32261616 Test: Visual Change-Id: I61ce67c23e27177e2915df012c450f77b40a8fb2 --- res/layout-land/choose_lock_pattern.xml | 57 +++++++++++-------- .../android/settings/ChooseLockPattern.java | 16 ++++++ 2 files changed, 49 insertions(+), 24 deletions(-) diff --git a/res/layout-land/choose_lock_pattern.xml b/res/layout-land/choose_lock_pattern.xml index 89e3d57a726..b4d5fceb938 100644 --- a/res/layout-land/choose_lock_pattern.xml +++ b/res/layout-land/choose_lock_pattern.xml @@ -41,37 +41,46 @@ android:layout_marginBottom="@dimen/suw_content_frame_padding_bottom" android:orientation="vertical"> - + android:layout_marginStart="0dp" + android:layout_marginEnd="0dp" + android:src="@drawable/ic_lock"/> - + - + android:orientation="vertical"> - + - - + + + + + + mChosenPattern = null; private boolean mHideDrawer = false; + // ScrollView that contains title and header, only exist in land mode + private ScrollView mTitleHeaderScrollView; + /** * The patten used during the help screen to show how to draw a pattern. */ @@ -237,6 +241,15 @@ public class ChooseLockPattern extends SettingsActivity { mFooterText.setText(""); mFooterLeftButton.setEnabled(false); mFooterRightButton.setEnabled(false); + + if (mTitleHeaderScrollView != null) { + mTitleHeaderScrollView.post(new Runnable() { + @Override + public void run() { + mTitleHeaderScrollView.fullScroll(ScrollView.FOCUS_DOWN); + } + }); + } } }; @@ -415,6 +428,9 @@ public class ChooseLockPattern extends SettingsActivity { mFooterLeftButton = (TextView) view.findViewById(R.id.footerLeftButton); mFooterRightButton = (TextView) view.findViewById(R.id.footerRightButton); + mTitleHeaderScrollView = (ScrollView) view.findViewById(R.id + .scroll_layout_title_header); + mFooterLeftButton.setOnClickListener(this); mFooterRightButton.setOnClickListener(this);