From a5d0c3e36e1430d28fcb934395252ccb30aacd1b Mon Sep 17 00:00:00 2001 From: Doris Ling Date: Tue, 30 Jan 2018 12:49:35 -0800 Subject: [PATCH] Remove suggestion UI v1 codes. - remove the check for feature flag for suggestion UI v2 and switch to use the v2 codes. - remove all code related to v1 of suggestion UI Fixes: 70573674 Test: make RunSettingsRoboTests Change-Id: I99ab318c1c0192508a9c5e9e708e86319120d55b --- ...dition_footer.xml => condition_footer.xml} | 0 ...dition_header.xml => condition_header.xml} | 0 res/layout/suggestion_condition_container.xml | 43 -- res/layout/suggestion_tile.xml | 86 ++-- res/layout/suggestion_tile_v2.xml | 82 ---- res/layout/suggestion_tile_with_button.xml | 78 +-- res/layout/suggestion_tile_with_button_v2.xml | 91 ---- .../android/settings/core/FeatureFlags.java | 1 - .../settings/dashboard/DashboardAdapter.java | 332 +++++-------- .../dashboard/DashboardAdapterV2.java | 429 ----------------- .../settings/dashboard/DashboardData.java | 167 +++---- .../settings/dashboard/DashboardDataV2.java | 446 ------------------ .../dashboard/DashboardFeatureProvider.java | 5 - .../DashboardFeatureProviderImpl.java | 5 - .../settings/dashboard/DashboardSummary.java | 88 +--- .../conditional/ConditionAdapter.java | 13 +- .../conditional/ConditionAdapterV2.java | 186 -------- .../suggestions/SuggestionAdapter.java | 172 ++++++- .../suggestions/SuggestionAdapterV2.java | 282 ----------- .../SuggestionDismissController.java | 90 ---- .../dashboard/DashboardAdapterTest.java | 186 +++++--- .../dashboard/DashboardAdapterV2Test.java | 286 ----------- .../settings/dashboard/DashboardDataTest.java | 47 +- .../dashboard/DashboardSummaryTest.java | 6 - .../conditional/ConditionAdapterTest.java | 51 +- .../conditional/ConditionAdapterV2Test.java | 135 ------ .../suggestions/SuggestionAdapterTest.java | 139 +++++- .../suggestions/SuggestionAdapterV2Test.java | 297 ------------ .../SuggestionDismissControllerTest.java | 117 ----- 29 files changed, 746 insertions(+), 3114 deletions(-) rename res/layout/{suggestion_condition_footer.xml => condition_footer.xml} (100%) rename res/layout/{suggestion_condition_header.xml => condition_header.xml} (100%) delete mode 100644 res/layout/suggestion_condition_container.xml delete mode 100644 res/layout/suggestion_tile_v2.xml delete mode 100644 res/layout/suggestion_tile_with_button_v2.xml delete mode 100644 src/com/android/settings/dashboard/DashboardAdapterV2.java delete mode 100644 src/com/android/settings/dashboard/DashboardDataV2.java delete mode 100644 src/com/android/settings/dashboard/conditional/ConditionAdapterV2.java delete mode 100644 src/com/android/settings/dashboard/suggestions/SuggestionAdapterV2.java delete mode 100644 src/com/android/settings/dashboard/suggestions/SuggestionDismissController.java delete mode 100644 tests/robotests/src/com/android/settings/dashboard/DashboardAdapterV2Test.java delete mode 100644 tests/robotests/src/com/android/settings/dashboard/conditional/ConditionAdapterV2Test.java delete mode 100644 tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionAdapterV2Test.java delete mode 100644 tests/robotests/src/com/android/settings/dashboard/suggestions/SuggestionDismissControllerTest.java diff --git a/res/layout/suggestion_condition_footer.xml b/res/layout/condition_footer.xml similarity index 100% rename from res/layout/suggestion_condition_footer.xml rename to res/layout/condition_footer.xml diff --git a/res/layout/suggestion_condition_header.xml b/res/layout/condition_header.xml similarity index 100% rename from res/layout/suggestion_condition_header.xml rename to res/layout/condition_header.xml diff --git a/res/layout/suggestion_condition_container.xml b/res/layout/suggestion_condition_container.xml deleted file mode 100644 index a4c60ad26a8..00000000000 --- a/res/layout/suggestion_condition_container.xml +++ /dev/null @@ -1,43 +0,0 @@ - - - - - - - - - - - - diff --git a/res/layout/suggestion_tile.xml b/res/layout/suggestion_tile.xml index b9474528c37..79f6dcae359 100644 --- a/res/layout/suggestion_tile.xml +++ b/res/layout/suggestion_tile.xml @@ -14,51 +14,69 @@ limitations under the License. --> - + app:cardPreventCornerOverlap="false" + app:cardUseCompatPadding="true" + app:cardElevation="2dp" + app:cardCornerRadius="@dimen/suggestion_card_corner_radius"> + android:minHeight="112dp" + android:orientation="vertical"> - - - + android:orientation="horizontal"> - + - + - + + + + + - - - \ No newline at end of file + diff --git a/res/layout/suggestion_tile_v2.xml b/res/layout/suggestion_tile_v2.xml deleted file mode 100644 index a7717b74cb3..00000000000 --- a/res/layout/suggestion_tile_v2.xml +++ /dev/null @@ -1,82 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - diff --git a/res/layout/suggestion_tile_with_button.xml b/res/layout/suggestion_tile_with_button.xml index 081df5b061f..a674bcb08b1 100644 --- a/res/layout/suggestion_tile_with_button.xml +++ b/res/layout/suggestion_tile_with_button.xml @@ -14,58 +14,78 @@ limitations under the License. --> - - - + app:cardPreventCornerOverlap="false" + app:cardUseCompatPadding="true" + app:cardElevation="2dp" + app:cardCornerRadius="@dimen/suggestion_card_corner_radius"> + + + + + + + + + style="@style/SuggestionCardText" + android:layout_marginStart="12dp" + android:layout_marginEnd="12dp" + android:singleLine="true" + android:textAppearance="@style/TextAppearance.SuggestionTitleV2" + android:ellipsize="end" + android:fadingEdge="horizontal" />