From ead637e0c8582a8c88f669fdd0879b4d05635c0c Mon Sep 17 00:00:00 2001 From: Ahmed ElArabawy Date: Mon, 9 Dec 2019 14:48:07 -0800 Subject: [PATCH] Wifi: Replace dual_band with 5GHz band support As part of the support of the 6GHz band, the concept of dual-band is no longer valid since we have more than 2 bands supported by Android and can be checked on the device. This commit replaces checks on dual-band support with an explicit check on 5GHz band support. Bug: 145936758 Bug: 139354972 Test: Manual Change-Id: Ia118dedb573f61a148764146edf8091ae253a3e2 --- .../WifiTetherApBandPreferenceController.java | 2 +- .../WifiTetherApBandPreferenceControllerTest.java | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceController.java b/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceController.java index ed422da0ad5..78e592c001d 100644 --- a/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceController.java +++ b/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceController.java @@ -129,7 +129,7 @@ public class WifiTetherApBandPreferenceController extends WifiTetherBasePreferen private boolean is5GhzBandSupported() { final String countryCode = mWifiManager.getCountryCode(); - if (!mWifiManager.isDualBandSupported() || countryCode == null) { + if (!mWifiManager.is5GHzBandSupported() || countryCode == null) { return false; } return true; diff --git a/tests/robotests/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceControllerTest.java index a0f2882a76b..8e7f9dbe4e4 100644 --- a/tests/robotests/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/tether/WifiTetherApBandPreferenceControllerTest.java @@ -82,7 +82,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void display_5GhzSupported_shouldDisplayFullList() { when(mWifiManager.getCountryCode()).thenReturn("US"); - when(mWifiManager.isDualBandSupported()).thenReturn(true); + when(mWifiManager.is5GHzBandSupported()).thenReturn(true); when(mWifiManager.isDualModeSupported()).thenReturn(true); mController.displayPreference(mScreen); @@ -94,7 +94,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void display_noCountryCode_shouldDisable() { when(mWifiManager.getCountryCode()).thenReturn(null); - when(mWifiManager.isDualBandSupported()).thenReturn(true); + when(mWifiManager.is5GHzBandSupported()).thenReturn(true); mController.displayPreference(mScreen); @@ -106,7 +106,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void display_5GhzNotSupported_shouldDisable() { when(mWifiManager.getCountryCode()).thenReturn("US"); - when(mWifiManager.isDualBandSupported()).thenReturn(false); + when(mWifiManager.is5GHzBandSupported()).thenReturn(false); mController.displayPreference(mScreen); @@ -118,7 +118,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void changePreference_noDualModeWith5G_shouldUpdateValue() { when(mWifiManager.getCountryCode()).thenReturn("US"); - when(mWifiManager.isDualBandSupported()).thenReturn(true); + when(mWifiManager.is5GHzBandSupported()).thenReturn(true); mController.displayPreference(mScreen); @@ -145,7 +145,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void changePreference_dualModeWith5G_shouldUpdateValue() { when(mWifiManager.getCountryCode()).thenReturn("US"); - when(mWifiManager.isDualBandSupported()).thenReturn(true); + when(mWifiManager.is5GHzBandSupported()).thenReturn(true); when(mWifiManager.isDualModeSupported()).thenReturn(true); mController.displayPreference(mScreen); @@ -172,7 +172,7 @@ public class WifiTetherApBandPreferenceControllerTest { @Test public void updateDisplay_shouldUpdateValue() { when(mWifiManager.getCountryCode()).thenReturn("US"); - when(mWifiManager.isDualBandSupported()).thenReturn(true); + when(mWifiManager.is5GHzBandSupported()).thenReturn(true); // Set controller band index to 1 and verify is set. mController.displayPreference(mScreen); @@ -180,7 +180,7 @@ public class WifiTetherApBandPreferenceControllerTest { assertThat(mController.getBandIndex()).isEqualTo(1); // Disable 5Ghz band - when(mWifiManager.isDualBandSupported()).thenReturn(false); + when(mWifiManager.is5GHzBandSupported()).thenReturn(false); // Call updateDisplay and verify it's changed. mController.updateDisplay();