PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Actually use the cache for names and icons.

Browse Source 
Fixes the flashes in name and icon in Battery usage screen when refreshing.
Bug: 8219466

Some earlier refactoring must have messed up the cache's scope. It will now
avoid reloading name and icon if already present in the cache.

Change-Id: I99c1f14dd53828dcb74cf12c02c47628e2e64d30
This commit is contained in:
Amith Yamasani
2013-02-19 10:40:33 -08:00
parent 595a891922
commit a521d11796
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/com/android/settings/fuelgauge/BatterySipper.java
View File

@@ -32,7 +32,8 @@ import java.util.HashMap;
class BatterySipper implements Comparable<BatterySipper> { class BatterySipper implements Comparable<BatterySipper> {
final Context mContext; final Context mContext;
final HashMap<String,UidToDetail> mUidCache = new HashMap<String,UidToDetail>(); /* Cache cleared when PowerUsageSummary is destroyed */
static final HashMap<String,UidToDetail> sUidCache = new HashMap<String,UidToDetail>();
final ArrayList<BatterySipper> mRequestQueue; final ArrayList<BatterySipper> mRequestQueue;
final Handler mHandler; final Handler mHandler;
String name; String name;
@@ -99,8 +100,8 @@ class BatterySipper implements Comparable<BatterySipper> {
void getQuickNameIconForUid(Uid uidObj) { void getQuickNameIconForUid(Uid uidObj) {
final int uid = uidObj.getUid(); final int uid = uidObj.getUid();
final String uidString = Integer.toString(uid); final String uidString = Integer.toString(uid);
if (mUidCache.containsKey(uidString)) { if (sUidCache.containsKey(uidString)) {
UidToDetail utd = mUidCache.get(uidString); UidToDetail utd = sUidCache.get(uidString);
defaultPackageName = utd.packageName; defaultPackageName = utd.packageName;
name = utd.name; name = utd.name;
icon = utd.icon; icon = utd.icon;
@@ -193,7 +194,7 @@ class BatterySipper implements Comparable<BatterySipper> {
utd.name = name; utd.name = name;
utd.icon = icon; utd.icon = icon;
utd.packageName = defaultPackageName; utd.packageName = defaultPackageName;
mUidCache.put(uidString, utd); sUidCache.put(uidString, utd);
mHandler.sendMessage(mHandler.obtainMessage(PowerUsageSummary.MSG_UPDATE_NAME_ICON, this)); mHandler.sendMessage(mHandler.obtainMessage(PowerUsageSummary.MSG_UPDATE_NAME_ICON, this));
} }
} }

2
src/com/android/settings/fuelgauge/PowerUsageSummary.java
View File

@@ -178,6 +178,8 @@ public class PowerUsageSummary extends PreferenceFragment implements Runnable {
super.onDestroy(); super.onDestroy();
if (getActivity().isChangingConfigurations()) { if (getActivity().isChangingConfigurations()) {
sStatsXfer = mStats; sStatsXfer = mStats;
} else {
BatterySipper.sUidCache.clear();
} }
} }