From c66a878813342708fcb766d1650202e771f02aa5 Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Mon, 10 Nov 2014 16:35:06 -0800 Subject: [PATCH] Fix bug #18104271 Tapping *name* of service in Voice input services does not fill in radio button - prevent sending onRadioButtonClicked() if the radio button is already checked - check the new current radio button Change-Id: I7e4457bcba6eb1abf51fbe3902bc0f6df0f4bdcf --- src/com/android/settings/voice/VoiceInputPreference.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/voice/VoiceInputPreference.java b/src/com/android/settings/voice/VoiceInputPreference.java index 0ebffbbbf85..38ef0ca6862 100644 --- a/src/com/android/settings/voice/VoiceInputPreference.java +++ b/src/com/android/settings/voice/VoiceInputPreference.java @@ -110,7 +110,9 @@ public final class VoiceInputPreference extends Preference { textLayout.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { - onRadioButtonClicked(rb, !rb.isChecked()); + if (!rb.isChecked()) { + onRadioButtonClicked(rb, true); + } } }); @@ -216,6 +218,7 @@ public final class VoiceInputPreference extends Preference { mSharedState.setCurrentKey(getKey()); updateCheckedState(true); callChangeListener(mSharedState.getCurrentKey()); + current.setChecked(true); } /**