From 24077d899fc4d0067759d0cd49ae62e3be01f949 Mon Sep 17 00:00:00 2001 From: Daniel Nishi Date: Mon, 8 May 2017 14:13:13 -0700 Subject: [PATCH] Add the badged icon for Movies & TV. The work profile was missing the icon. Change-Id: I005cc2baecfe86479156e19e0c4ec4b586336cff Fixes: 38132211 Test: Settings robotest --- res/xml/storage_profile_fragment.xml | 9 ++++++--- .../storage/StorageItemPreferenceController.java | 1 + .../storage/StorageItemPreferenceControllerTest.java | 5 +++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/res/xml/storage_profile_fragment.xml b/res/xml/storage_profile_fragment.xml index 04852795c10..be269e5513a 100644 --- a/res/xml/storage_profile_fragment.xml +++ b/res/xml/storage_profile_fragment.xml @@ -35,15 +35,18 @@ android:order="4" /> + android:title="@string/storage_movies_tv" + android:icon="@drawable/ic_theaters_vd_theme_24" + android:order="5" + /> + android:order="6" /> + android:order="7" /> diff --git a/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceController.java b/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceController.java index 4ce785a2739..f8df375588e 100644 --- a/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceController.java +++ b/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceController.java @@ -196,6 +196,7 @@ public class StorageItemPreferenceController extends PreferenceController { PackageManager pm = mContext.getPackageManager(); badgePreference(pm, userHandle, mPhotoPreference); + badgePreference(pm, userHandle, mMoviesPreference); badgePreference(pm, userHandle, mAudioPreference); badgePreference(pm, userHandle, mGamePreference); badgePreference(pm, userHandle, mAppPreference); diff --git a/tests/robotests/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceControllerTest.java index bc42d1f1033..e8057a62b14 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/storage/StorageItemPreferenceControllerTest.java @@ -298,6 +298,8 @@ public class StorageItemPreferenceControllerTest { public void settingUserIdAppliesNewIcons() { StorageItemPreference audio = spy(new StorageItemPreference(mContext)); audio.setIcon(R.drawable.ic_photo_library_vd_theme_24); + StorageItemPreference video = spy(new StorageItemPreference(mContext)); + video.setIcon(R.drawable.ic_photo_library_vd_theme_24); StorageItemPreference image = spy(new StorageItemPreference(mContext)); image.setIcon(R.drawable.ic_photo_library_vd_theme_24); StorageItemPreference games = spy(new StorageItemPreference(mContext)); @@ -311,6 +313,8 @@ public class StorageItemPreferenceControllerTest { PreferenceScreen screen = mock(PreferenceScreen.class); when(screen.findPreference( eq(StorageItemPreferenceController.AUDIO_KEY))).thenReturn(audio); + when(screen.findPreference( + eq(StorageItemPreferenceController.MOVIES_KEY))).thenReturn(video); when(screen.findPreference( eq(StorageItemPreferenceController.PHOTO_KEY))).thenReturn(image); when(screen.findPreference( @@ -326,6 +330,7 @@ public class StorageItemPreferenceControllerTest { mController.setUserId(new UserHandle(10)); verify(audio, times(2)).setIcon(any(Drawable.class)); + verify(video, times(2)).setIcon(any(Drawable.class)); verify(image, times(2)).setIcon(any(Drawable.class)); verify(games, times(2)).setIcon(any(Drawable.class)); verify(apps, times(2)).setIcon(any(Drawable.class));