PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix broken tests.

Browse Source 
This test was passing in invalid values for the namespace and key.
Modify it to use the correct ones.

Change-Id: Idc6971c20d64b711953bdde9fe710f592b04e807
Fixes: 124077137
Test: atest VibrateWhenRingPreferenceControllerTest
This commit is contained in:
Joel Galenson
2019-02-07 19:36:21 -08:00
parent 09f76a0298
commit a330abba0a
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/robotests/src/com/android/settings/notification/VibrateWhenRingPreferenceControllerTest.java
View File

@@ -81,7 +81,7 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void display_shouldDisplay() { public void display_shouldDisplay() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(true); when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
DeviceConfig.setProperty("namespace", "key", "false", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "false", false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mPreference.isVisible()).isTrue(); assertThat(mPreference.isVisible()).isTrue();
} }
@@ -89,7 +89,7 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void display_shouldNotDisplay_notVoiceCapable() { public void display_shouldNotDisplay_notVoiceCapable() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(false); when(mTelephonyManager.isVoiceCapable()).thenReturn(false);
DeviceConfig.setProperty("namespace", "key", "false", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "false", false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mPreference.isVisible()).isFalse(); assertThat(mPreference.isVisible()).isFalse();
} }
@@ -97,7 +97,7 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void display_shouldNotDisplay_RampingRingerEnabled() { public void display_shouldNotDisplay_RampingRingerEnabled() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(true); when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
DeviceConfig.setProperty("namespace", "key", "true", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "true", false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mPreference.isVisible()).isFalse(); assertThat(mPreference.isVisible()).isFalse();
} }
@@ -105,7 +105,7 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void display_shouldNotDisplay_VoiceEnabled_RampingRingerEnabled() { public void display_shouldNotDisplay_VoiceEnabled_RampingRingerEnabled() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(true); when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
DeviceConfig.setProperty("namespace", "key", "true", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "true", false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mPreference.isVisible()).isFalse(); assertThat(mPreference.isVisible()).isFalse();
} }
@@ -113,7 +113,7 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void display_shouldNotDisplay_VoiceDisabled_RampingRingerEnabled() { public void display_shouldNotDisplay_VoiceDisabled_RampingRingerEnabled() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(false); when(mTelephonyManager.isVoiceCapable()).thenReturn(false);
DeviceConfig.setProperty("namespace", "key", "true", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "true", false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mPreference.isVisible()).isFalse(); assertThat(mPreference.isVisible()).isFalse();
} }
@@ -139,14 +139,14 @@ public class VibrateWhenRingPreferenceControllerTest {
@Test @Test
public void voiceCapable_availabled() { public void voiceCapable_availabled() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(true); when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
DeviceConfig.setProperty("namespace", "key", "false", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "false", false);
assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE); assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);
} }
@Test @Test
public void voiceCapable_notAvailabled() { public void voiceCapable_notAvailabled() {
when(mTelephonyManager.isVoiceCapable()).thenReturn(false); when(mTelephonyManager.isVoiceCapable()).thenReturn(false);
DeviceConfig.setProperty("namespace", "key", "false", false); DeviceConfig.setProperty("telephony", "ramping_ringer_enabled", "false", false);
assertThat(mController.getAvailabilityStatus()).isEqualTo(UNSUPPORTED_ON_DEVICE); assertThat(mController.getAvailabilityStatus()).isEqualTo(UNSUPPORTED_ON_DEVICE);
} }