PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Stop calling LockPatternUtils.setVisiblePasswordEnabled()"

Browse Source
This commit is contained in:
Eric Biggers
2023-02-21 17:59:21 +00:00
committed by Android (Google) Code Review
parent 25d4014a0a bcee8ce1af
commit a31c9d506c
2 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/robotests/src/com/android/settings/security/ShowPasswordPreferenceControllerTest.java
View File

@@ -18,20 +18,15 @@ package com.android.settings.security;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.content.ContentResolver;
import android.content.Context;
import android.os.UserHandle;
import android.provider.Settings;
import androidx.preference.Preference;
import androidx.preference.PreferenceScreen;
import com.android.internal.widget.LockPatternUtils;
import com.android.settings.testutils.FakeFeatureFactory;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -44,12 +39,9 @@ import org.robolectric.annotation.Config;
@RunWith(RobolectricTestRunner.class)
public class ShowPasswordPreferenceControllerTest {
@Mock
private LockPatternUtils mLockPatternUtils;
@Mock
private PreferenceScreen mScreen;
private FakeFeatureFactory mFeatureFactory;
private Context mContext;
private ShowPasswordPreferenceController mController;
private Preference mPreference;
@@ -58,9 +50,6 @@ public class ShowPasswordPreferenceControllerTest {
public void setUp() {
MockitoAnnotations.initMocks(this);
mContext = RuntimeEnvironment.application;
mFeatureFactory = FakeFeatureFactory.setupForTest();
when(mFeatureFactory.securityFeatureProvider.getLockPatternUtils(mContext))
.thenReturn(mLockPatternUtils);
mController = new ShowPasswordPreferenceController(mContext);
mPreference = new Preference(mContext);
mPreference.setKey(mController.getPreferenceKey());
@@ -98,7 +87,6 @@ public class ShowPasswordPreferenceControllerTest {
mController.onPreferenceChange(mPreference, true);
assertThat(mController.isChecked()).isTrue();
verify(mLockPatternUtils).setVisiblePasswordEnabled(true, UserHandle.myUserId());
}
@Test
@@ -106,6 +94,5 @@ public class ShowPasswordPreferenceControllerTest {
mController.onPreferenceChange(mPreference, false);
assertThat(mController.isChecked()).isFalse();
verify(mLockPatternUtils).setVisiblePasswordEnabled(false, UserHandle.myUserId());
}
}