From a2d5ba3ebebcdc257e00f87d40eb37b73bff3577 Mon Sep 17 00:00:00 2001 From: Yanting Yang Date: Thu, 14 May 2020 04:24:57 +0800 Subject: [PATCH] Fix text view padding issue in EmptyTextSettings Set the left and right padding of text view to 24dp. Impact pages: Apps & notifications > Special app access > Premium SMS access Apps & notifications > Special app access > VR helper services Fixes: 147901392 Test: visual Change-Id: I01aa7935462e4d16e56be71a8f1f0cbe9b8275f9 --- res/values/dimens.xml | 3 +++ src/com/android/settings/widget/EmptyTextSettings.java | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/res/values/dimens.xml b/res/values/dimens.xml index a7e003c5e5b..c6b2dc2cf11 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -430,4 +430,7 @@ 12dp + + + 24dp diff --git a/src/com/android/settings/widget/EmptyTextSettings.java b/src/com/android/settings/widget/EmptyTextSettings.java index 24f0a821f4b..87513dd5fe3 100644 --- a/src/com/android/settings/widget/EmptyTextSettings.java +++ b/src/com/android/settings/widget/EmptyTextSettings.java @@ -25,6 +25,7 @@ import android.view.ViewGroup; import android.view.ViewGroup.LayoutParams; import android.widget.TextView; +import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; public abstract class EmptyTextSettings extends SettingsPreferenceFragment { @@ -36,6 +37,9 @@ public abstract class EmptyTextSettings extends SettingsPreferenceFragment { super.onViewCreated(view, savedInstanceState); mEmpty = new TextView(getContext()); mEmpty.setGravity(Gravity.CENTER); + final int textPadding = getContext().getResources().getDimensionPixelSize( + R.dimen.empty_text_padding); + mEmpty.setPadding(textPadding, 0 /* top */, textPadding, 0 /* bottom */); TypedValue value = new TypedValue(); getContext().getTheme().resolveAttribute(android.R.attr.textAppearanceMedium, value, true); mEmpty.setTextAppearance(value.resourceId);