PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Settings: trampoline persist.logd.logpersistd to logd.logpersistd"

Browse Source
This commit is contained in:
Treehugger Robot
2016-07-13 17:45:44 +00:00
committed by Gerrit Code Review
parent 3c60540078 98849ce7ae
commit a1b40f0267
1 changed files with 47 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
src/com/android/settings/DevelopmentSettings.java
View File

@@ -161,10 +161,13 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
private static final String SELECT_LOGD_OFF_SIZE_MARKER_VALUE = "32768"; private static final String SELECT_LOGD_OFF_SIZE_MARKER_VALUE = "32768";
private static final String SELECT_LOGPERSIST_KEY = "select_logpersist"; private static final String SELECT_LOGPERSIST_KEY = "select_logpersist";
private static final String SELECT_LOGPERSIST_PROPERTY = "persist.logd.logpersistd"; private static final String SELECT_LOGPERSIST_PROPERTY = "persist.logd.logpersistd";
private static final String ACTUAL_LOGPERSIST_PROPERTY = "logd.logpersistd";
private static final String SELECT_LOGPERSIST_PROPERTY_SERVICE = "logcatd"; private static final String SELECT_LOGPERSIST_PROPERTY_SERVICE = "logcatd";
private static final String SELECT_LOGPERSIST_PROPERTY_CLEAR = "clear"; private static final String SELECT_LOGPERSIST_PROPERTY_CLEAR = "clear";
private static final String SELECT_LOGPERSIST_PROPERTY_STOP = "stop"; private static final String SELECT_LOGPERSIST_PROPERTY_STOP = "stop";
private static final String SELECT_LOGPERSIST_PROPERTY_BUFFER = "persist.logd.logpersistd.buffer"; private static final String SELECT_LOGPERSIST_PROPERTY_BUFFER = "persist.logd.logpersistd.buffer";
private static final String ACTUAL_LOGPERSIST_PROPERTY_BUFFER = "logd.logpersistd.buffer";
private static final String ACTUAL_LOGPERSIST_PROPERTY_ENABLE = "logd.logpersistd.enable";
private static final String WIFI_DISPLAY_CERTIFICATION_KEY = "wifi_display_certification"; private static final String WIFI_DISPLAY_CERTIFICATION_KEY = "wifi_display_certification";
private static final String WIFI_VERBOSE_LOGGING_KEY = "wifi_verbose_logging"; private static final String WIFI_VERBOSE_LOGGING_KEY = "wifi_verbose_logging";
@@ -1355,13 +1358,17 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
String currentValue = SystemProperties.get(SELECT_LOGD_SIZE_PROPERTY); String currentValue = SystemProperties.get(SELECT_LOGD_SIZE_PROPERTY);
if ((currentTag != null) && currentTag.startsWith(SELECT_LOGD_TAG_SILENCE)) { if ((currentTag != null) && currentTag.startsWith(SELECT_LOGD_TAG_SILENCE)) {
currentValue = SELECT_LOGD_OFF_SIZE_MARKER_VALUE; currentValue = SELECT_LOGD_OFF_SIZE_MARKER_VALUE;
if (mLogpersist != null) { }
writeLogpersistOption(null, true); if (mLogpersist != null) {
mLogpersist.setEnabled(false); String currentLogpersistEnable
} = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY_ENABLE);
} else { if ((currentLogpersistEnable == null)
if ((mLogpersist != null) && mLastEnabledState) { || !currentLogpersistEnable.equals("true")
mLogpersist.setEnabled(true); || currentValue.equals(SELECT_LOGD_OFF_SIZE_MARKER_VALUE)) {
writeLogpersistOption(null, true);
mLogpersist.setEnabled(false);
} else if (mLastEnabledState) {
mLogpersist.setEnabled(true);
} }
} }
if ((currentValue == null) || (currentValue.length() == 0)) { if ((currentValue == null) || (currentValue.length() == 0)) {
@@ -1435,11 +1442,11 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
if (mLogpersist == null) { if (mLogpersist == null) {
return; return;
} }
String currentValue = SystemProperties.get(SELECT_LOGPERSIST_PROPERTY); String currentValue = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY);
if (currentValue == null) { if (currentValue == null) {
currentValue = ""; currentValue = "";
} }
String currentBuffers = SystemProperties.get(SELECT_LOGPERSIST_PROPERTY_BUFFER); String currentBuffers = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY_BUFFER);
if ((currentBuffers == null) || (currentBuffers.length() == 0)) { if ((currentBuffers == null) || (currentBuffers.length() == 0)) {
currentBuffers = "all"; currentBuffers = "all";
} }
@@ -1471,7 +1478,7 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
mLogpersistCleared = false; mLogpersistCleared = false;
} else if (!mLogpersistCleared) { } else if (!mLogpersistCleared) {
// would File.delete() directly but need to switch uid/gid to access // would File.delete() directly but need to switch uid/gid to access
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY, SELECT_LOGPERSIST_PROPERTY_CLEAR); SystemProperties.set(ACTUAL_LOGPERSIST_PROPERTY, SELECT_LOGPERSIST_PROPERTY_CLEAR);
pokeSystemProperties(); pokeSystemProperties();
mLogpersistCleared = true; mLogpersistCleared = true;
} }
@@ -1479,11 +1486,25 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
private void setLogpersistOff(boolean update) { private void setLogpersistOff(boolean update) {
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY_BUFFER, ""); SystemProperties.set(SELECT_LOGPERSIST_PROPERTY_BUFFER, "");
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY, // deal with trampoline of empty properties
SystemProperties.set(ACTUAL_LOGPERSIST_PROPERTY_BUFFER, "");
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY, "");
SystemProperties.set(ACTUAL_LOGPERSIST_PROPERTY,
update ? "" : SELECT_LOGPERSIST_PROPERTY_STOP); update ? "" : SELECT_LOGPERSIST_PROPERTY_STOP);
pokeSystemProperties(); pokeSystemProperties();
if (update) { if (update) {
updateLogpersistValues(); updateLogpersistValues();
} else {
for (int i = 0; i < 3; i++) {
String currentValue = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY);
if ((currentValue == null) || currentValue.equals("")) {
break;
}
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
}
} }
} }
@@ -1502,8 +1523,9 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
mLogpersistCleared = false; mLogpersistCleared = false;
} else if (!mLogpersistCleared) { } else if (!mLogpersistCleared) {
// if transitioning from on to off, pop up an are you sure? // if transitioning from on to off, pop up an are you sure?
String currentValue = SystemProperties.get(SELECT_LOGPERSIST_PROPERTY); String currentValue = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY);
if ((currentValue != null) && (currentValue.length() != 0)) { if ((currentValue != null) &&
currentValue.equals(SELECT_LOGPERSIST_PROPERTY_SERVICE)) {
if (mLogpersistClearDialog != null) dismissDialogs(); if (mLogpersistClearDialog != null) dismissDialogs();
mLogpersistClearDialog = new AlertDialog.Builder(getActivity()).setMessage( mLogpersistClearDialog = new AlertDialog.Builder(getActivity()).setMessage(
getActivity().getResources().getString( getActivity().getResources().getString(
@@ -1520,13 +1542,24 @@ public class DevelopmentSettings extends SettingsPreferenceFragment
return; return;
} }
String currentBuffer = SystemProperties.get(SELECT_LOGPERSIST_PROPERTY_BUFFER); String currentBuffer = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY_BUFFER);
if ((currentBuffer != null) && !currentBuffer.equals(newValue.toString())) { if ((currentBuffer != null) && !currentBuffer.equals(newValue.toString())) {
setLogpersistOff(false); setLogpersistOff(false);
} }
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY_BUFFER, newValue.toString()); SystemProperties.set(SELECT_LOGPERSIST_PROPERTY_BUFFER, newValue.toString());
SystemProperties.set(SELECT_LOGPERSIST_PROPERTY, SELECT_LOGPERSIST_PROPERTY_SERVICE); SystemProperties.set(SELECT_LOGPERSIST_PROPERTY, SELECT_LOGPERSIST_PROPERTY_SERVICE);
pokeSystemProperties(); pokeSystemProperties();
for (int i = 0; i < 3; i++) {
String currentValue = SystemProperties.get(ACTUAL_LOGPERSIST_PROPERTY);
if ((currentValue != null)
&& currentValue.equals(SELECT_LOGPERSIST_PROPERTY_SERVICE)) {
break;
}
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
}
updateLogpersistValues(); updateLogpersistValues();
} }