From 30c1767c0a66307c7800caffee29419c9a555d13 Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Tue, 10 Sep 2019 11:41:35 +0800 Subject: [PATCH] [Wi-Fi] Fix robolectric test broken 1. WifiConfigController#setSelection triggers onItemSelect, it uses mEapUserCertSpinner without adapter. 2. refreshSummary should use parameter preference instead of mPreference. Bug: 140771897 Test: WifiConfigControllerTest WifiWakeupPreferenceControllerTest Change-Id: I963260bd82e7387052cacae89bdbe46da841e341 --- .../android/settings/wifi/WifiConfigController.java | 10 +++++----- .../settings/wifi/WifiWakeupPreferenceController.java | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/com/android/settings/wifi/WifiConfigController.java b/src/com/android/settings/wifi/WifiConfigController.java index f2bc0a2efbf..8bb023da428 100644 --- a/src/com/android/settings/wifi/WifiConfigController.java +++ b/src/com/android/settings/wifi/WifiConfigController.java @@ -1070,17 +1070,17 @@ public class WifiConfigController implements TextWatcher, mDoNotValidateEapServerString, false, true); - // To avoid the user connects to a non-secure network unexpectedly, - // request using system trusted certificates by default - // unless the user explicitly chooses "Do not validate" or other - // CA certificates. - setSelection(mEapCaCertSpinner, mUseSystemCertsString); loadCertificates( mEapUserCertSpinner, Credentials.USER_PRIVATE_KEY, mDoNotProvideEapUserCertString, false, false); + // To avoid the user connects to a non-secure network unexpectedly, + // request using system trusted certificates by default + // unless the user explicitly chooses "Do not validate" or other + // CA certificates. + setSelection(mEapCaCertSpinner, mUseSystemCertsString); } // Modifying an existing network diff --git a/src/com/android/settings/wifi/WifiWakeupPreferenceController.java b/src/com/android/settings/wifi/WifiWakeupPreferenceController.java index 75b714a0dea..855b329e627 100644 --- a/src/com/android/settings/wifi/WifiWakeupPreferenceController.java +++ b/src/com/android/settings/wifi/WifiWakeupPreferenceController.java @@ -118,7 +118,7 @@ public class WifiWakeupPreferenceController extends TogglePreferenceController i @Override public void updateState(Preference preference) { super.updateState(preference); - refreshSummary(mPreference); + refreshSummary(preference); } @Override