[Testcase] To migration MobileNetworkSwitchControllerTest

1. Use AndroidJunit4 instead of RobolectricTestRunner
2. Use ApplicationProvider instead of RuntimeEnvironment
   to get context
3. Change Copy Right

Bug: 173385220
Test: atest MobileNetworkSwitchControllerTest

Change-Id: I127ba4123dd8e144dbf7778865a08582657f7195
This commit is contained in:
SongFerngWang
2020-11-16 21:44:34 +08:00
parent d58a9cdd05
commit 9f3c6e7cb3

View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2019 The Android Open Source Project * Copyright (C) 2020 The Android Open Source Project
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -27,11 +27,18 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import android.content.Context; import android.content.Context;
import android.os.Looper;
import android.telephony.SubscriptionInfo; import android.telephony.SubscriptionInfo;
import android.telephony.SubscriptionManager; import android.telephony.SubscriptionManager;
import android.test.UiThreadTest;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.android.settings.R;
import com.android.settings.network.SubscriptionUtil; import com.android.settings.network.SubscriptionUtil;
import com.android.settings.testutils.ResourcesUtils;
import com.android.settings.widget.SwitchBar; import com.android.settings.widget.SwitchBar;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
@@ -42,43 +49,35 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
import org.mockito.MockitoAnnotations; import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import java.util.Arrays; import java.util.Arrays;
import androidx.lifecycle.LifecycleOwner; @RunWith(AndroidJUnit4.class)
import androidx.preference.PreferenceScreen;
@RunWith(RobolectricTestRunner.class)
public class MobileNetworkSwitchControllerTest { public class MobileNetworkSwitchControllerTest {
@Mock @Mock
private SubscriptionManager mSubscriptionManager; private SubscriptionManager mSubscriptionManager;
@Mock @Mock
private PreferenceScreen mScreen; private SubscriptionInfo mSubscription;
@Mock
private Lifecycle mLifecycle;
@Mock @Mock
private LayoutPreference mLayoutPreference; private LayoutPreference mLayoutPreference;
@Mock
private SubscriptionInfo mSubscription;
private Context mContext; private PreferenceScreen mScreen;
private LifecycleOwner mLifecycleOwner; private PreferenceManager mPreferenceManager;
private Lifecycle mLifecycle;
private MobileNetworkSwitchController mController;
private SwitchBar mSwitchBar; private SwitchBar mSwitchBar;
private Context mContext;
private MobileNetworkSwitchController mController;
private int mSubId = 123; private int mSubId = 123;
@Before @Before
public void setUp() { public void setUp() {
MockitoAnnotations.initMocks(this); MockitoAnnotations.initMocks(this);
mContext = spy(RuntimeEnvironment.application); mContext = spy(ApplicationProvider.getApplicationContext());
when(mContext.getSystemService(SubscriptionManager.class)).thenReturn(mSubscriptionManager); when(mContext.getSystemService(SubscriptionManager.class)).thenReturn(mSubscriptionManager);
when(mSubscriptionManager.setSubscriptionEnabled(eq(mSubId), anyBoolean())) when(mSubscriptionManager.setSubscriptionEnabled(eq(mSubId), anyBoolean()))
.thenReturn(true); .thenReturn(true);
mLifecycleOwner = () -> mLifecycle;
mLifecycle = new Lifecycle(mLifecycleOwner);
when(mSubscription.isEmbedded()).thenReturn(true); when(mSubscription.isEmbedded()).thenReturn(true);
when(mSubscription.getSubscriptionId()).thenReturn(mSubId); when(mSubscription.getSubscriptionId()).thenReturn(mSubId);
// Most tests want to have 2 available subscriptions so that the switch bar will show. // Most tests want to have 2 available subscriptions so that the switch bar will show.
@@ -90,9 +89,18 @@ public class MobileNetworkSwitchControllerTest {
mController = new MobileNetworkSwitchController(mContext, key); mController = new MobileNetworkSwitchController(mContext, key);
mController.init(mLifecycle, mSubscription.getSubscriptionId()); mController.init(mLifecycle, mSubscription.getSubscriptionId());
if (Looper.myLooper() == null) {
Looper.prepare();
}
mPreferenceManager = new PreferenceManager(mContext);
mScreen = mPreferenceManager.createPreferenceScreen(mContext);
mScreen.addPreference(mLayoutPreference);
mSwitchBar = new SwitchBar(mContext); mSwitchBar = new SwitchBar(mContext);
when(mScreen.findPreference(key)).thenReturn(mLayoutPreference); doReturn(key).when(mLayoutPreference).getKey();
when(mLayoutPreference.findViewById(R.id.switch_bar)).thenReturn(mSwitchBar); when(mLayoutPreference.findViewById(
ResourcesUtils.getResourcesId(mContext, "id", "switch_bar"))).thenReturn(
mSwitchBar);
} }
@After @After
@@ -101,6 +109,7 @@ public class MobileNetworkSwitchControllerTest {
} }
@Test @Test
@UiThreadTest
public void isAvailable_pSIM_isNotAvailable() { public void isAvailable_pSIM_isNotAvailable() {
when(mSubscription.isEmbedded()).thenReturn(false); when(mSubscription.isEmbedded()).thenReturn(false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
@@ -112,6 +121,7 @@ public class MobileNetworkSwitchControllerTest {
} }
@Test @Test
@UiThreadTest
public void displayPreference_oneEnabledSubscription_switchBarNotHidden() { public void displayPreference_oneEnabledSubscription_switchBarNotHidden() {
doReturn(true).when(mSubscriptionManager).isActiveSubscriptionId(mSubId); doReturn(true).when(mSubscriptionManager).isActiveSubscriptionId(mSubId);
SubscriptionUtil.setAvailableSubscriptionsForTesting(Arrays.asList(mSubscription)); SubscriptionUtil.setAvailableSubscriptionsForTesting(Arrays.asList(mSubscription));
@@ -120,14 +130,18 @@ public class MobileNetworkSwitchControllerTest {
} }
@Test @Test
@UiThreadTest
public void displayPreference_oneDisabledSubscription_switchBarNotHidden() { public void displayPreference_oneDisabledSubscription_switchBarNotHidden() {
doReturn(false).when(mSubscriptionManager).isActiveSubscriptionId(mSubId); doReturn(false).when(mSubscriptionManager).isActiveSubscriptionId(mSubId);
SubscriptionUtil.setAvailableSubscriptionsForTesting(Arrays.asList(mSubscription)); SubscriptionUtil.setAvailableSubscriptionsForTesting(Arrays.asList(mSubscription));
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mSwitchBar.isShowing()).isTrue(); assertThat(mSwitchBar.isShowing()).isTrue();
} }
@Test @Test
@UiThreadTest
public void displayPreference_subscriptionEnabled_switchIsOn() { public void displayPreference_subscriptionEnabled_switchIsOn() {
when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(true); when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(true);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
@@ -136,24 +150,31 @@ public class MobileNetworkSwitchControllerTest {
} }
@Test @Test
@UiThreadTest
public void displayPreference_subscriptionDisabled_switchIsOff() { public void displayPreference_subscriptionDisabled_switchIsOff() {
when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(false); when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mSwitchBar.isShowing()).isTrue(); assertThat(mSwitchBar.isShowing()).isTrue();
assertThat(mSwitchBar.isChecked()).isFalse(); assertThat(mSwitchBar.isChecked()).isFalse();
} }
@Test @Test
@UiThreadTest
public void switchChangeListener_fromEnabledToDisabled_setSubscriptionEnabledCalledCorrectly() { public void switchChangeListener_fromEnabledToDisabled_setSubscriptionEnabledCalledCorrectly() {
when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(true); when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(true);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mSwitchBar.isShowing()).isTrue(); assertThat(mSwitchBar.isShowing()).isTrue();
assertThat(mSwitchBar.isChecked()).isTrue(); assertThat(mSwitchBar.isChecked()).isTrue();
mSwitchBar.setChecked(false); mSwitchBar.setChecked(false);
verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(false)); verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(false));
} }
@Test @Test
@UiThreadTest
public void switchChangeListener_fromEnabledToDisabled_setSubscriptionEnabledFailed() { public void switchChangeListener_fromEnabledToDisabled_setSubscriptionEnabledFailed() {
when(mSubscriptionManager.setSubscriptionEnabled(eq(mSubId), anyBoolean())) when(mSubscriptionManager.setSubscriptionEnabled(eq(mSubId), anyBoolean()))
.thenReturn(false); .thenReturn(false);
@@ -161,18 +182,23 @@ public class MobileNetworkSwitchControllerTest {
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mSwitchBar.isShowing()).isTrue(); assertThat(mSwitchBar.isShowing()).isTrue();
assertThat(mSwitchBar.isChecked()).isTrue(); assertThat(mSwitchBar.isChecked()).isTrue();
mSwitchBar.setChecked(false); mSwitchBar.setChecked(false);
verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(false)); verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(false));
assertThat(mSwitchBar.isChecked()).isTrue(); assertThat(mSwitchBar.isChecked()).isTrue();
} }
@Test @Test
@UiThreadTest
public void switchChangeListener_fromDisabledToEnabled_setSubscriptionEnabledCalledCorrectly() { public void switchChangeListener_fromDisabledToEnabled_setSubscriptionEnabledCalledCorrectly() {
when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(false); when(mSubscriptionManager.isActiveSubscriptionId(mSubId)).thenReturn(false);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
assertThat(mSwitchBar.isShowing()).isTrue(); assertThat(mSwitchBar.isShowing()).isTrue();
assertThat(mSwitchBar.isChecked()).isFalse(); assertThat(mSwitchBar.isChecked()).isFalse();
mSwitchBar.setChecked(true); mSwitchBar.setChecked(true);
verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(true)); verify(mSubscriptionManager).setSubscriptionEnabled(eq(mSubId), eq(true));
} }
} }