From 9eb7ab195d5ed0f9ea498eccd8b60612d1d9c5b4 Mon Sep 17 00:00:00 2001 From: Daniel Norman Date: Wed, 27 Sep 2023 23:50:28 +0000 Subject: [PATCH] Remove importantForA11y=no from a11y activity launch preference. Due to how Preferences create a single node for their content, this was causing that node to lack the ACTION_CLICK action and clickable attribute. Removing this attribute properly exposes the click action which means that TalkBack will now speak "double tap to activate" and Switch Access will highlight the button while scanning. See http://recall/-/bznujeSAo20YqWFB1N28dO/gVdpAXoD3BroEkUeJBTUWq Flag: RESOURCES_ONLY Bug: 301528206 Test: Open Settings > Accessibility > Sound Notifications; Use TalkBack to highlight and speak the "Open Sound Notifications" button; observe "double tap to activate". Repeat with Switch Access; observe button is highlighted while scanning and can be selected. Change-Id: Ie747e19fe149d015cf92fbe07fd71cfaf183d795 --- res/layout/accessibility_launch_activity_preference.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/res/layout/accessibility_launch_activity_preference.xml b/res/layout/accessibility_launch_activity_preference.xml index 679120663ef..f3841e262a7 100644 --- a/res/layout/accessibility_launch_activity_preference.xml +++ b/res/layout/accessibility_launch_activity_preference.xml @@ -21,8 +21,7 @@ android:paddingEnd="?android:attr/listPreferredItemPaddingEnd" android:paddingStart="?android:attr/listPreferredItemPaddingStart" android:paddingVertical="@dimen/settingslib_switchbar_margin" - android:background="@android:color/transparent" - android:importantForAccessibility="no"> + android:background="@android:color/transparent">