diff --git a/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java b/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java index dfb59d19787..5f3cbb28dcc 100644 --- a/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java +++ b/src/com/android/settings/wifi/details/WifiDetailPreferenceController.java @@ -441,8 +441,9 @@ public class WifiDetailPreferenceController extends AbstractPreferenceController if (usingDataUsageHeader(mContext)) { mSummaryHeaderController.updateState(mDataUsageSummaryPref); } else { - mEntityHeaderController.setSummary(mAccessPoint.getSettingsSummary()) - .done(mFragment.getActivity(), true /* rebind */); + mEntityHeaderController.setSummary( + mAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .done(mFragment.getActivity(), true /* rebind */); } } diff --git a/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java index 3ffe61a7729..9a1dd4c0f82 100644 --- a/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/wifi/details/WifiDetailPreferenceControllerTest.java @@ -519,13 +519,23 @@ public class WifiDetailPreferenceControllerTest { public void entityHeader_shouldHaveSummarySet() { setUpForConnectedNetwork(); String summary = "summary"; - when(mockAccessPoint.getSettingsSummary()).thenReturn(summary); + when(mockAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .thenReturn(summary); displayAndResume(); verify(mockHeaderController).setSummary(summary); } + @Test + public void entityHeader_shouldConvertSavedAsDisconnected() { + setUpForDisconnectedNetwork(); + + displayAndResume(); + + verify(mockAccessPoint, times(1)).getSettingsSummary(true /*convertSavedAsDisconnected*/); + } + @Test public void signalStrengthPref_shouldHaveIconSetForConnectedNetwork() { setUpForConnectedNetwork(); @@ -950,7 +960,8 @@ public class WifiDetailPreferenceControllerTest { .thenReturn(new NetworkCapabilities(nc)); String summary = "Connected, no Internet"; - when(mockAccessPoint.getSettingsSummary()).thenReturn(summary); + when(mockAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .thenReturn(summary); InOrder inOrder = inOrder(mockHeaderController); displayAndResume(); @@ -959,7 +970,8 @@ public class WifiDetailPreferenceControllerTest { // Check that an irrelevant capability update does not update the access point summary, as // doing so could cause unnecessary jank... summary = "Connected"; - when(mockAccessPoint.getSettingsSummary()).thenReturn(summary); + when(mockAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .thenReturn(summary); updateNetworkCapabilities(nc); inOrder.verify(mockHeaderController, never()).setSummary(any(CharSequence.class)); @@ -969,7 +981,8 @@ public class WifiDetailPreferenceControllerTest { inOrder.verify(mockHeaderController).setSummary(summary); summary = "Connected, no Internet"; - when(mockAccessPoint.getSettingsSummary()).thenReturn(summary); + when(mockAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .thenReturn(summary); // Another irrelevant update won't cause the UI to refresh... updateNetworkCapabilities(nc); @@ -982,7 +995,8 @@ public class WifiDetailPreferenceControllerTest { // UI will be refreshed when device connects to a partial connectivity network. summary = "Limited connection"; - when(mockAccessPoint.getSettingsSummary()).thenReturn(summary); + when(mockAccessPoint.getSettingsSummary(true /*convertSavedAsDisconnected*/)) + .thenReturn(summary); nc.addCapability(NetworkCapabilities.NET_CAPABILITY_PARTIAL_CONNECTIVITY); updateNetworkCapabilities(nc); inOrder.verify(mockHeaderController).setSummary(summary);