Merge changes from topic "catalyst-firmware-version" into main

* changes:
  Migrate "Build number" preference
  Migrate "Kernel version" preference
  Migrate "Baseband version" preference
This commit is contained in:
Jacky Wang
2024-09-23 15:44:09 +00:00
committed by Android (Google) Code Review
14 changed files with 327 additions and 3 deletions

View File

@@ -38,6 +38,7 @@ import org.robolectric.RuntimeEnvironment;
import java.util.Arrays;
// LINT.IfChange
@RunWith(RobolectricTestRunner.class)
public class BasebandVersionPreferenceControllerTest {
@Mock
@@ -68,3 +69,4 @@ public class BasebandVersionPreferenceControllerTest {
assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);
}
}
// LINT.ThenChange(BasebandVersionPreferenceTest.kt)

View File

@@ -0,0 +1,60 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.deviceinfo.firmwareversion
import android.content.Context
import android.content.ContextWrapper
import android.sysprop.TelephonyProperties
import android.telephony.TelephonyManager
import androidx.test.core.app.ApplicationProvider
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.robolectric.RobolectricTestRunner
// LINT.IfChange
@RunWith(RobolectricTestRunner::class)
class BasebandVersionPreferenceTest {
private lateinit var telephonyManager: TelephonyManager
private val context: Context =
object : ContextWrapper(ApplicationProvider.getApplicationContext()) {
override fun getSystemService(name: String): Any? =
when {
name == getSystemServiceName(TelephonyManager::class.java) -> telephonyManager
else -> super.getSystemService(name)
}
}
private val basebandVersionPreference = BasebandVersionPreference()
@Test
fun isAvailable_wifiOnly_unavailable() {
telephonyManager = mock { on { isDataCapable } doReturn false }
assertThat(basebandVersionPreference.isAvailable(context)).isFalse()
}
@Test
fun isAvailable_hasMobile_available() {
TelephonyProperties.baseband_version(listOf("test"))
telephonyManager = mock { on { isDataCapable } doReturn true }
assertThat(basebandVersionPreference.isAvailable(context)).isTrue()
}
}
// LINT.ThenChange(BasebandVersionPreferenceControllerTest.java)

View File

@@ -29,6 +29,7 @@ import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
// LINT.IfChange
@RunWith(RobolectricTestRunner.class)
public class KernelVersionPreferenceControllerTest {
@@ -49,3 +50,4 @@ public class KernelVersionPreferenceControllerTest {
DeviceInfoUtils.getFormattedKernelVersion(mContext));
}
}
// LINT.ThenChange(KernelVersionPreferenceTest.kt)

View File

@@ -0,0 +1,40 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.deviceinfo.firmwareversion
import android.content.Context
import androidx.test.core.app.ApplicationProvider
import com.android.settingslib.DeviceInfoUtils
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
// LINT.IfChange
@RunWith(RobolectricTestRunner::class)
class KernelVersionPreferenceTest {
private val context: Context = ApplicationProvider.getApplicationContext()
private val kernelVersionPreference = KernelVersionPreference()
@Test
fun getSummary() {
assertThat(kernelVersionPreference.getSummary(context))
.isEqualTo(DeviceInfoUtils.getFormattedKernelVersion(context))
}
}
// LINT.ThenChange(KernelVersionPreferenceControllerTest.java)

View File

@@ -29,6 +29,7 @@ import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
// LINT.IfChange
@RunWith(RobolectricTestRunner.class)
public class SimpleBuildNumberPreferenceControllerTest {
@@ -48,3 +49,4 @@ public class SimpleBuildNumberPreferenceControllerTest {
assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE);
}
}
// LINT.ThenChange(SimpleBuildNumberPreferenceTest.kt)

View File

@@ -0,0 +1,55 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.deviceinfo.firmwareversion
import android.content.Context
import android.os.Build
import android.text.BidiFormatter
import androidx.test.core.app.ApplicationProvider
import com.google.common.truth.Truth.assertThat
import java.util.Locale
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
// LINT.IfChange
@RunWith(RobolectricTestRunner::class)
class SimpleBuildNumberPreferenceTest {
private val context: Context = ApplicationProvider.getApplicationContext()
private val simpleBuildNumberPreference = SimpleBuildNumberPreference()
@Test
fun isIndexable() {
assertThat(simpleBuildNumberPreference.isIndexable(context)).isFalse()
}
@Test
fun getSummary_ltr() {
context.resources.configuration.setLayoutDirection(Locale.ENGLISH)
assertThat(simpleBuildNumberPreference.getSummary(context))
.isEqualTo(BidiFormatter.getInstance(false).unicodeWrap(Build.DISPLAY))
}
@Test
fun getSummary_rtl() {
context.resources.configuration.setLayoutDirection(Locale("ar"))
assertThat(simpleBuildNumberPreference.getSummary(context))
.isEqualTo(BidiFormatter.getInstance(true).unicodeWrap(Build.DISPLAY))
}
}
// LINT.ThenChange(SimpleBuildNumberPreferenceControllerTest.java)