From 9c69ded434ffcc182b6cf98c1f1f37b6539f8c34 Mon Sep 17 00:00:00 2001 From: Tsung-Mao Fang Date: Tue, 7 Apr 2020 15:40:02 +0800 Subject: [PATCH] The text on toast should be changed when remains 1 time for SIM lock input This cl was cherry-picked from aosp/585306 The behavior of getQuantityString() is different according to language, it gets both "other" and "one" string if English is system language. But it always gets "other" string if non-English, then the "other" string of wrong_pin_code is shown even if remains 1 time of SIM lock input. In order to change the string in any language, we add new string for remains 1 time. Test: Rebuild rom Fix: 71783850 Change-Id: If4b53bbbc6b51582bc0837abf4497d9a75ebbaad --- res/values/strings.xml | 4 ++++ src/com/android/settings/IccLockSettings.java | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 8a642ac1fa9..cd738c3f732 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -3017,6 +3017,10 @@ Incorrect SIM PIN code, you have %d remaining attempt before you must contact your carrier to unlock your device. Incorrect SIM PIN code, you have %d remaining attempts. + + + Incorrect SIM PIN code, you have 1 remaining attempt before you must contact your carrier to unlock your device. SIM PIN operation failed! diff --git a/src/com/android/settings/IccLockSettings.java b/src/com/android/settings/IccLockSettings.java index 4340039cf3e..8c48e65dd77 100644 --- a/src/com/android/settings/IccLockSettings.java +++ b/src/com/android/settings/IccLockSettings.java @@ -639,7 +639,9 @@ public class IccLockSettings extends SettingsPreferenceFragment if (attemptsRemaining == 0) { displayMessage = mRes.getString(R.string.wrong_pin_code_pukked); - } else if (attemptsRemaining > 0) { + } else if (attemptsRemaining == 1) { + displayMessage = mRes.getString(R.string.wrong_pin_code_one, attemptsRemaining); + } else if (attemptsRemaining > 1) { displayMessage = mRes .getQuantityString(R.plurals.wrong_pin_code, attemptsRemaining, attemptsRemaining);